From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] MIPS64: Fix xpcall() error case.
Date: Wed, 11 Feb 2026 10:17:52 +0300 [thread overview]
Message-ID: <aYwtIPtWodu_YZyz@root> (raw)
In-Reply-To: <501e08d75b66efe4221def8226d5b43820cc8490.1765350224.git.sergeyb@tarantool.org>
Hi, Sergey!
Thanks for the patch!
LGTM, with minor nits.
On 10.12.25, Sergey Bronnikov wrote:
> From: Mike Pall <mike>
>
> Thanks to François Perrad and Stefan Pejic.
>
> (cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)
>
> The patch fixes `xpcall()` segfaults on MIPS64 commit. The similar
Typo: s/commit/architecture/
> patch for ARM64 has been backported previously, see the commit
Minor: s/backported previously/backported (with the test) previously/
> af889e4608e6eca495dd85e6161d8bcd7d3628e6 ("ARM64: Fix xpcall()
> error case (really).").
>
> Sergey Bronnikov:
> * added the description
>
> Part of tarantool/tarantool#12134
> ---
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2026-02-11 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 7:23 [Tarantool-patches] [PATCH luajit 0/3][v2] Fix stack overflow in pcall/xpcall Sergey Bronnikov via Tarantool-patches
2025-12-10 7:23 ` [Tarantool-patches] [PATCH luajit 1/3] MIPS64: Fix xpcall() error case Sergey Bronnikov via Tarantool-patches
2026-02-11 7:17 ` Sergey Kaplun via Tarantool-patches [this message]
2025-12-10 7:23 ` [Tarantool-patches] [PATCH luajit 2/3][v2] LJ_FR2: Fix stack checks in vararg calls Sergey Bronnikov via Tarantool-patches
2026-02-11 8:30 ` Sergey Kaplun via Tarantool-patches
2025-12-10 7:23 ` [Tarantool-patches] [PATCH luajit 3/3][v2] Add stack check to pcall/xpcall Sergey Bronnikov via Tarantool-patches
2026-02-11 10:24 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYwtIPtWodu_YZyz@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/3] MIPS64: Fix xpcall() error case.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox