Re: [Tarantool-patches] [PATCH luajit 3/3] macOS: Remove obsolete -single_module flag.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
See my clarification below.

On 26.11.25, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch! LGTM with two minor comments.
> 
> Sergey
> 
> On 11/24/25 23:26, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Thanks to dundargoc.
> >
> > (cherry picked from commit 97813fb924edf822455f91a5fbbdfdb349e5984f)
> >
> > The aforementioned flag is the default since Xcode 2.2 [1].
> 
> You refer to the description in the previous commit, right?
> 
> I would name a flag here instead

It is mentioned in the commit message header, so I refer to the commit
message header, not the previous commit. Hence, I don't see the reason
to mention it again.

> 
> > This patch removes this flag to avoid warnings for modern Xcode
> > versions at the linking stage.
> it is worth to mention our own modifications for CMake build system

I suppose this is excess since this is the details of the
implemenatation.

> >

<snipped>

-- 
Best regards,
Sergey Kaplun