From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64
Date: Mon, 21 Jul 2025 15:29:49 +0300 [thread overview]
Message-ID: <aH4yvX6M1PwI82Xr@root> (raw)
In-Reply-To: <7c148026-9ddc-4b6e-898a-b84c170c0eb2@tarantool.org>
Hi, Sergey!
Thanks for the review!
On 21.07.25, Sergey Bronnikov wrote:
> Hello, Sergey,
>
> thanks for the patch!
>
> > [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64
>
> s/or/on/?
No, since I've meant that either Tarantool or the corresponding arch
doesn't run this test.
>
> On 7/21/25 11:16, Sergey Kaplun wrote:
> > The test may lead to the assertion failure if run under Tarantool.
> > Also, the skip condition for the Tarantool leads to stable fails for
> > some builds on x86/x64 architecture, so they are skipped as well.
> > See details in the comment to the skip conditions.
> > ---
>
> I suppose you want to disable it temporarily, do we need an issue as a
> reminder?
I suppose not. It should be enabled back alongside the backporting
commit for the 1369.
>
> LGTM
> >
> > Branch:https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool
> >
> > Originally I want to disable the test only for Tarantool, but faced
> > multiple failures in the different workflows:
> > https://github.com/tarantool/luajit/actions/runs/16410069543
> >
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2025-07-21 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 8:16 Sergey Kaplun via Tarantool-patches
2025-07-21 12:20 ` Sergey Bronnikov via Tarantool-patches
2025-07-21 12:29 ` Sergey Kaplun via Tarantool-patches [this message]
2025-07-21 12:38 ` Sergey Bronnikov via Tarantool-patches
2025-07-21 12:42 ` Sergey Kaplun via Tarantool-patches
2025-07-21 12:42 ` Sergey Bronnikov via Tarantool-patches
2025-07-25 9:21 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH4yvX6M1PwI82Xr@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox