From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] Fix potential file descriptor leak in luaL_loadfile*().
Date: Fri, 6 Jun 2025 18:14:52 +0300 [thread overview]
Message-ID: <aEMF7Bna3Er0efoF@root> (raw)
In-Reply-To: <da537450-b22c-4fe3-8b45-9bcfd0248a04@tarantool.org>
Hi, Sergey!
Thanks for the review!
On 06.06.25, Sergey Bronnikov wrote:
> Hello, Sergey,
>
> the test is passed when CMake option -DLUAJIT_USE_VALGRIND=ON is used and
>
> patch with fix is reverted.
You should run it with the corresponding env variable (like it is done
in the CI), see the comment in the test header:
| VALGRIND_OPTS="--track-fds=yes" ctest -V -R lj-1249
>
> Sergey
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2025-06-06 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 5:44 [Tarantool-patches] [PATCH luajit 0/3] Fix descriptor leak in loadfile Sergey Kaplun via Tarantool-patches
2025-06-05 5:44 ` [Tarantool-patches] [PATCH luajit 1/3] ci: add track-fds Valgrind scenario Sergey Kaplun via Tarantool-patches
2025-06-06 13:56 ` Sergey Bronnikov via Tarantool-patches
2025-06-06 14:03 ` Sergey Kaplun via Tarantool-patches
2025-06-06 14:54 ` Sergey Bronnikov via Tarantool-patches
2025-06-06 15:31 ` Sergey Kaplun via Tarantool-patches
2025-06-05 5:44 ` [Tarantool-patches] [PATCH luajit 2/3] Fix potential file descriptor leak in luaL_loadfile*() Sergey Kaplun via Tarantool-patches
2025-06-06 14:47 ` Sergey Bronnikov via Tarantool-patches
2025-06-06 15:14 ` Sergey Kaplun via Tarantool-patches [this message]
2025-06-06 15:49 ` Sergey Bronnikov via Tarantool-patches
2025-06-05 5:44 ` [Tarantool-patches] [PATCH luajit 3/3] Fix another " Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEMF7Bna3Er0efoF@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/3] Fix potential file descriptor leak in luaL_loadfile*().' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox