From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>,
tarantool-patches@dev.tarantool.org,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] tuple: fix non-informative update() error message
Date: Sat, 30 Nov 2019 02:04:10 +0100 [thread overview]
Message-ID: <a92c2929-3911-f90d-1d14-8a866f015a9a@tarantool.org> (raw)
In-Reply-To: <20191130000942.38265-1-k.sosnin@tarantool.org>
Thanks for the fixes!
LGTM.
On 30/11/2019 01:09, Chris Sosnin wrote:
> Sorry for my mistake again, here is the diff:
> + const char *str = tt_sprintf("wrong number of arguments, "\
> + "expected %u, got %u",
> + op->meta->arg_count, arg_count);
>
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-3884-update-error
> issue: https://github.com/tarantool/tarantool/issues/3884
>
prev parent reply other threads:[~2019-11-30 1:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 8:53 Chris Sosnin
2019-11-27 22:55 ` Vladislav Shpilevoy
2019-11-28 12:28 ` Chris Sosnin
2019-11-29 23:25 ` Vladislav Shpilevoy
2019-11-30 0:09 ` Chris Sosnin
2019-11-30 1:04 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a92c2929-3911-f90d-1d14-8a866f015a9a@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] tuple: fix non-informative update() error message' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox