Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, imeevma@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v6 0/7] sql: set column types for EXPLAIN and PRAGMA
Date: Mon, 25 Feb 2019 14:59:40 +0300	[thread overview]
Message-ID: <a90d3827-a918-8954-1d68-22472c664932@tarantool.org> (raw)
In-Reply-To: <cover.1550753723.git.imeevma@gmail.com>

Hi! Thanks for the fixes!

On 21/02/2019 16:00, imeevma@tarantool.org wrote:
> This patch-set defines the types for the result columns of EXPLAIN
> and PRAGMA commands. In addition, it fixes some problems of the
> PRAGMA commands that have something to do with their result.
> 
> https://github.com/tarantool/tarantool/issues/3832
> https://github.com/tarantool/tarantool/tree/imeevma/gh-3832-no-column-types
> 
> Changes in sixth version:
>    - Rebase to current 2.1
>    - New patch that removes gh-3733-pragma.test.lua
>    - Other small fixes.

Neither of these things are worth sending new patches in a
new thread with a bumped version. Please, next time try to
keep the discussion in the same thread if no drastic changes.

The patchset is good now.

Now, please, add docbot request to the last commit,
describing changes in PRAGMA output. Including all the
previous commits too. I mean, that 'PRAGMA' now returns
name/value pairs, how now 'EXPLAIN' works, that
'sql_default_engine' and 'case_sensitive_like' return a
current value, what does 'parser_trace', etc.

Do not resend a new version. Just add a docbot request,
signal here about it, and I will say LGTM.

  parent reply	other threads:[~2019-02-25 11:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 13:00 [tarantool-patches] " imeevma
2019-02-21 13:00 ` [tarantool-patches] [PATCH v6 1/7] sql: remove unused macros from pragma.c and pragma.h imeevma
2019-02-21 13:00 ` [tarantool-patches] [PATCH v6 2/7] sql: fix "PRAGMA parser_trace" result imeevma
2019-02-21 13:00 ` [tarantool-patches] [PATCH v6 3/7] sql: Show currently set sql_default_engine imeevma
2019-02-21 15:52   ` [tarantool-patches] " Konstantin Osipov
2019-02-21 13:00 ` [tarantool-patches] [PATCH v6 4/7] sql: fix "PRAGMA case_sensitive_like" result imeevma
2019-02-21 13:00 ` [tarantool-patches] [PATCH v6 5/7] sql: get results of PRAGMA statement as result set imeevma
2019-02-21 13:00 ` [tarantool-patches] [PATCH v6 6/7] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-02-21 13:00 ` [tarantool-patches] [PATCH v6 7/7] sql: remove test gh-3733-pragma.test.lua imeevma
2019-02-25 11:59 ` Vladislav Shpilevoy [this message]
2019-02-25 21:05   ` [tarantool-patches] Re: [PATCH v6 0/7] sql: set column types for EXPLAIN and PRAGMA Imeev Mergen
2019-02-26  9:33     ` Vladislav Shpilevoy
2019-02-27 11:09 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a90d3827-a918-8954-1d68-22472c664932@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v6 0/7] sql: set column types for EXPLAIN and PRAGMA' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox