Re: [Tarantool-patches] [PATCH luajit 19/19] MIPS: Add MIPS64 R6 port.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!


thanks for the patch!

LGTM, after fixing extra whitespace in commit message.


Sergey

On 8/9/23 18:36, Sergey Kaplun wrote:
> From: Mike Pall <mike>
>
> Contributed by Hua Zhang, YunQiang Su from Wave Computing,
> and Radovan Birdic from RT-RK.
> Sponsored by Wave Computing.
>
> (cherry-picked from commit 94d0b53004a5fa368defa4307a17edcdb87fe727)
>
> This patch adds support for MIPS Release 6 [1] for the 64-bit build.
> This includes:
> * Global `_map_def` value is set with <dynasm/dynasm.lua>. `MIPSR6` key
>    specifies the corresponding instruction set support. Also, `MIPSR6` is
>    defined in `DYNASM_FLAGS` (`DASM_AFLAGS`).
> * New instructions are added within <dynasm/dasm_mips.lua>, they are
>    used if the aforementioned key is set.
> * Obsolete instructions (that are no more in use in r6) are used in the
>    opposite case (if `MIPSR6` isn't set).
> * New opcode maps are added into  <src/jit/dis_mips.lua>.
Nit: double whitespace before "<".


<snipped>