From: Stanislav Zudin <szudin@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Georgy Kirichenko <georgy@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH v2] core: Non-blocking io.popen
Date: Tue, 4 Jun 2019 10:11:15 +0300 [thread overview]
Message-ID: <a790628e-ebf4-f84a-a7ac-ceb854dad201@tarantool.org> (raw)
In-Reply-To: <20190603172525.cia2tkbjui56rbaj@tkn_work_nb>
On 03.06.2019 20:25, Alexander Turenko wrote:
>>> Come to think of it, we might need an explicit knob to destroy an object
>>> even before it's collected. May be, consider re-adding close() for this?
>>> Please consult with Alexander and/or Georgy re this.
>>>
>>
>> Sasha, George, what do you think?
>
> I'm a bit out of context. Why we need explicit close()? To control
> reaching a file descriptor limit? It can be worked around with
> `handle = nil collectgarbage()`, but an explicit close() looks better.
> Maybe it worth to add.
>
For now there is wait() as a final method. It waits for process
termination and releases resources.
So the question was: should we add close() to release resources
explicitly?
Anyway there is a finalizer who performs a final cleanup for the case
when user forgot to do it.
next prev parent reply other threads:[~2019-06-04 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 7:08 Stanislav Zudin
2019-05-30 18:34 ` Vladimir Davydov
2019-05-31 8:13 ` [tarantool-patches] " Konstantin Osipov
2019-06-03 15:52 ` Stanislav Zudin
2019-06-03 17:25 ` Alexander Turenko
2019-06-04 7:11 ` Stanislav Zudin [this message]
2019-06-04 7:59 ` Vladimir Davydov
2019-06-05 3:49 ` Alexander Turenko
2019-06-04 11:14 ` Vladimir Davydov
2019-06-04 22:39 ` Alexander Turenko
2019-05-31 11:49 ` Vladimir Davydov
2019-05-31 17:32 ` [tarantool-patches] " Konstantin Osipov
2019-05-31 17:49 ` Vladimir Davydov
2019-06-03 15:53 ` Stanislav Zudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a790628e-ebf4-f84a-a7ac-ceb854dad201@tarantool.org \
--to=szudin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH v2] core: Non-blocking io.popen' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox