Re: [Tarantool-patches] [PATCH 1/4] test: add infrastructure for fuzzing testing and fuzzers

[Sergey Bronnikov <sergeyb@tarantool.org>]

On 25.12.2020 12:02, Igor Munkin wrote:
> Sergey,
>
> On 25.12.20, Sergey Bronnikov wrote:
>> On 24.12.2020 20:50, Igor Munkin wrote:
>>> Sergey,
>>>
>>> On 24.12.20, Sergey Bronnikov wrote:
>>>> Igor,
>>>>
>>> <snipped>
>>>
>>>>>>>>> 2. Do you need to specify <address> flag once more, when ASAN is
>>>>>>>>> enabled? If not the hunk above looks excess, doesn't it?
>>>>>>>> Agree, it was a bad idea to manage UBSan and ASAN flags in yet another
>>>>>>>> place.
>>>>> I guess this should be fixed in scope of the first patch, but I see you
>>>>> squashed it to the last one. Why?
>>>> It seems because I was triggered by OSS_FUZZ in hunk and squashed it to
>>>> a commit
>>>>
>>>> that introduce an OSS_FUZZ support. Fixed it and also moved
>>>> add_compile_options() to the first commit too
>>>>
>>>> (otherwise project source code is not instrumented with
>>>> -fsanitize=fuzzer-no-link).
>>> OK, but I believe we agreed the <address> options should be removed to
>>> avoid managing ASAN flags here, didn't we?
>> Removed asan option and double space in commit message.
> See no changes on the branch.
>
Sorry, pushed.

CI (not started yet) 
https://gitlab.com/tarantool/tarantool/-/pipelines/234413198


> <snipped>
>
>