From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 2/5] feedback_daemon: rename `send_test` to `send`
Date: Thu, 8 Apr 2021 16:38:38 +0300 [thread overview]
Message-ID: <a6d9ffffd8f7c14713e758a9fe3cb3ab95c5a579.1617888916.git.sergepetrenko@tarantool.org> (raw)
In-Reply-To: <cover.1617888916.git.sergepetrenko@tarantool.org>
feedback_daemon.send() will come in handy once we implement triggers to
dispatch feedback after some events, for example, right on initial
instance configuration.
So, it's not a testing method anymore, hence the new name.
Part of #5750
---
src/box/lua/feedback_daemon.lua | 2 +-
test/box-tap/feedback_daemon.test.lua | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua
index 8820bcde5..d00eedf39 100644
--- a/src/box/lua/feedback_daemon.lua
+++ b/src/box/lua/feedback_daemon.lua
@@ -412,7 +412,7 @@ setmetatable(daemon, {
reload = function()
reload(daemon)
end,
- send_test = function()
+ send = function()
if daemon.control ~= nil then
daemon.control:put("send")
end
diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
index e1c450d2b..3d6bf1d9b 100755
--- a/test/box-tap/feedback_daemon.test.lua
+++ b/test/box-tap/feedback_daemon.test.lua
@@ -93,28 +93,28 @@ feedback_reset()
errinj.set("ERRINJ_HTTPC", false)
check('feedback received after errinj')
-daemon.send_test()
+daemon.send()
check("feedback received after explicit sending")
box.cfg{feedback_enabled = false}
feedback_reset()
-daemon.send_test()
+daemon.send()
test:ok(feedback_count == 0, "no feedback after disabling")
box.cfg{feedback_enabled = true}
-daemon.send_test()
+daemon.send()
check("feedback after start")
daemon.stop()
feedback_reset()
-daemon.send_test()
+daemon.send()
test:ok(feedback_count == 0, "no feedback after stop")
daemon.start()
-daemon.send_test()
+daemon.send()
check("feedback after start")
-daemon.send_test()
-check("feedback after feedback send_test")
+daemon.send()
+check("feedback after feedback send")
daemon.stop()
@@ -136,7 +136,7 @@ server:close()
-- check it does not fail without server
daemon = box.internal.feedback_daemon
daemon.start()
-daemon.send_test()
+daemon.send()
daemon.stop()
--
--
2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2021-04-08 13:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:38 [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 1/5] feedback_daemon: include server uptime in the report Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` Serge Petrenko via Tarantool-patches [this message]
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 3/5] feedback_daemon: send feedback on server start Serge Petrenko via Tarantool-patches
2021-04-09 21:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:03 ` Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 4/5] feedback_daemon: generate report right before sending Serge Petrenko via Tarantool-patches
2021-04-09 21:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:03 ` Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 5/5] feedback_daemon: count and report some events Serge Petrenko via Tarantool-patches
2021-04-13 8:31 ` Alexander Turenko via Tarantool-patches
2021-04-13 10:38 ` Serge Petrenko via Tarantool-patches
2021-04-11 14:15 ` [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events Vladislav Shpilevoy via Tarantool-patches
2021-04-12 6:04 ` Kirill Yukhin via Tarantool-patches
2021-04-13 9:44 ` Alexander Turenko via Tarantool-patches
2021-04-12 6:05 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d9ffffd8f7c14713e758a9fe3cb3ab95c5a579.1617888916.git.sergepetrenko@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/5] feedback_daemon: rename `send_test` to `send`' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox