From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream
Date: Wed, 8 Nov 2023 18:47:28 +0300 [thread overview]
Message-ID: <a67f3905-0ab2-42e8-99c8-62653b1c2794@tarantool.org> (raw)
In-Reply-To: <1689345019.547057052@f380.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
Hi, Max
sorry for a delayed answer.
LGTM with a minor comment
On 7/14/23 17:30, Maxim Kokryashkin wrote:
>
<snipped>
>
>
> > +end
> > +
> > +res, err = misc.sysprof.stop()
> > +assert(res, err)
> > +
> > +test:ok(true, 'sysprof finished successfully')
>
I propose to reflect a goal of the test in a test description. Please
add something about ffunc to description.
The test is not about whole sysprof, but about ffunc support in sysprof.
> > +
> > +os.exit(test:check() and 0 or 1)
>
>
[-- Attachment #2: Type: text/html, Size: 2015 bytes --]
next prev parent reply other threads:[~2023-11-08 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 12:28 Maxim Kokryashkin via Tarantool-patches
2023-07-13 8:12 ` Sergey Bronnikov via Tarantool-patches
2023-07-14 14:30 ` Maxim Kokryashkin via Tarantool-patches
2023-11-08 15:47 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-11-08 23:01 ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 7:06 ` Sergey Bronnikov via Tarantool-patches
2023-07-15 15:36 ` Sergey Kaplun via Tarantool-patches
2023-07-17 12:52 ` Maxim Kokryashkin via Tarantool-patches
2023-11-23 6:32 ` Igor Munkin via Tarantool-patches
-- strict thread matches above, loose matches on Subject: below --
2023-07-05 8:56 Maxim Kokryashkin via Tarantool-patches
2023-07-09 12:21 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67f3905-0ab2-42e8-99c8-62653b1c2794@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox