Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH v1] test: remove unused test files
@ 2021-01-15 16:19 Sergey Bronnikov via Tarantool-patches
  2021-01-17 16:23 ` Vladislav Shpilevoy via Tarantool-patches
  2021-01-18 13:45 ` Kirill Yukhin via Tarantool-patches
  0 siblings, 2 replies; 3+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2021-01-15 16:19 UTC (permalink / raw)
  To: tarantool-patches, v.shpilevoy

From: Sergey Bronnikov <sergeyb@tarantool.org>

Closes #5169
---

Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/242261206
Issue: https://github.com/tarantool/tarantool/issues/5169
Branch: ligurio/gh-5169-remove-unused-test-files

 .luacheckrc                   |  6 -----
 test/box/lua/require_init.lua |  5 ----
 test/box/lua/require_mod.lua  |  7 ------
 test/box/lua/test_init.lua    | 45 -----------------------------------
 4 files changed, 63 deletions(-)
 delete mode 100644 test/box/lua/require_init.lua
 delete mode 100644 test/box/lua/require_mod.lua
 delete mode 100644 test/box/lua/test_init.lua

diff --git a/.luacheckrc b/.luacheckrc
index 497b1efc8..84c6fb5eb 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -33,12 +33,6 @@ exclude_files = {
     "test-run/**/*.lua",
     "test/app/*.test.lua",
     "test/box/*.test.lua",
-    -- Unused source file, to be dropped (gh-5169).
-    "test/box/lua/require_init.lua",
-    -- Unused source file, to be dropped (gh-5169).
-    "test/box/lua/require_mod.lua",
-    -- Unused source file, to be dropped (gh-5169).
-    "test/box/lua/test_init.lua",
     "test/engine/**/*.lua",
     "test/engine_long/**/*.lua",
     "test/long_run-py/**/*.lua",
diff --git a/test/box/lua/require_init.lua b/test/box/lua/require_init.lua
deleted file mode 100644
index c9ab07dce..000000000
--- a/test/box/lua/require_init.lua
+++ /dev/null
@@ -1,5 +0,0 @@
-#!/usr/bin/env tarantool
-box.load_cfg()
-mod = require("require_mod")
-package_path = package.path
-package_cpath = package.cpath
diff --git a/test/box/lua/require_mod.lua b/test/box/lua/require_mod.lua
deleted file mode 100644
index d708a8608..000000000
--- a/test/box/lua/require_mod.lua
+++ /dev/null
@@ -1,7 +0,0 @@
-exports = {}
-
-function exports.test(a, b)
-  return a+b
-end
-
-return exports
diff --git a/test/box/lua/test_init.lua b/test/box/lua/test_init.lua
deleted file mode 100644
index 88cc3acdc..000000000
--- a/test/box/lua/test_init.lua
+++ /dev/null
@@ -1,45 +0,0 @@
-#!/usr/bin/env tarantool
-box.load_cfg()
--- testing start-up script
-floor = require("math").floor
-
---
--- Access to box.cfg from start-up script
---
-
-box_cfg = box.cfg()
-
-function print_config()
-	return box_cfg
-end
-
-
---
--- Test for bug #977898
--- Insert from detached fiber
---
-
-local function do_insert()
-    box.fiber.detach()
-    box.space[0]:insert{1, 2, 4, 8}
-end
-
-space = box.schema.create_space('tweedledum', { id = 0 })
-space:create_index('primary', { type = 'hash' })
-
-fiber = box.fiber.create(do_insert)
-box.fiber.resume(fiber)
-
---
--- Test insert from start-up script
---
-
-space:insert{2, 4, 8, 16}
-
---
--- A test case for https://github.com/tarantool/tarantool/issues/53
---
-
-assert (require ~= nil)
-box.fiber.sleep(0.0)
-assert (require ~= nil)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Tarantool-patches] [PATCH v1] test: remove unused test files
  2021-01-15 16:19 [Tarantool-patches] [PATCH v1] test: remove unused test files Sergey Bronnikov via Tarantool-patches
@ 2021-01-17 16:23 ` Vladislav Shpilevoy via Tarantool-patches
  2021-01-18 13:45 ` Kirill Yukhin via Tarantool-patches
  1 sibling, 0 replies; 3+ messages in thread
From: Vladislav Shpilevoy via Tarantool-patches @ 2021-01-17 16:23 UTC (permalink / raw)
  To: sergeyb, tarantool-patches

Thanks for the patch!

LGTM.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Tarantool-patches] [PATCH v1] test: remove unused test files
  2021-01-15 16:19 [Tarantool-patches] [PATCH v1] test: remove unused test files Sergey Bronnikov via Tarantool-patches
  2021-01-17 16:23 ` Vladislav Shpilevoy via Tarantool-patches
@ 2021-01-18 13:45 ` Kirill Yukhin via Tarantool-patches
  1 sibling, 0 replies; 3+ messages in thread
From: Kirill Yukhin via Tarantool-patches @ 2021-01-18 13:45 UTC (permalink / raw)
  To: sergeyb; +Cc: tarantool-patches, v.shpilevoy

Hello,

On 15 янв 19:19, Sergey Bronnikov via Tarantool-patches wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #5169
> ---
> 
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/242261206
> Issue: https://github.com/tarantool/tarantool/issues/5169
> Branch: ligurio/gh-5169-remove-unused-test-files

I've checked your patch into 2.6, 2.7 and master.

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-18 13:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 16:19 [Tarantool-patches] [PATCH v1] test: remove unused test files Sergey Bronnikov via Tarantool-patches
2021-01-17 16:23 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-18 13:45 ` Kirill Yukhin via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox