From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH v2 09/11] raft: introduce state machine
Date: Wed, 23 Sep 2020 22:31:07 +0200 [thread overview]
Message-ID: <a655ceea-5862-4690-4e14-823ee7a9c8e6@tarantool.org> (raw)
In-Reply-To: <7a9e07de-5f24-ed4b-3749-74a4dbedabb3@tarantool.org>
>> diff --git a/src/box/raft.c b/src/box/raft.c
>> index f712887a1..ce90ed533 100644
>> --- a/src/box/raft.c
>> +++ b/src/box/raft.c
>> @@ -177,16 +178,9 @@ raft_election_quorum(void)
>> - /* Can't vote when vclock is unknown. */
>> - if (req->vclock == NULL) {
>> - say_info("RAFT: vote request is skipped - "
>> - "missing candidate vclock.");
>> - break;
>> - }
>> - /* Can't vote for too old or incomparable nodes. */
>> - if (!raft_can_vote_for(req->vclock)) {
>> + if (req->state != RAFT_STATE_CANDIDATE) {
>> say_info("RAFT: vote request is skipped - "
>> - "the vclock is not acceptable = %s",
>> - vclock_to_string(req->vclock));
>> + "this is a notification about a vote "
>> + "for a third node, not a request");
>> break;
>> }
>> - /*
>> - * Check if somebody is asking to vote for a third
>> - * node - nope. Make votes only when asked directly by
>> - * the new candidate. However that restriction may be
>> - * relaxed in future, if can be proven to be safe.
>> - */
>> - if (req->vote != source) {
>> + if (raft.volatile_vote != 0) {
>> say_info("RAFT: vote request is skipped - "
>> - "indirect votes are not allowed");
>> + "already voted in this term");
>> break;
>> }
>> - if (raft.leader != 0) {
>> + /* Vclock is not NULL, validated above. */
>> + if (!raft_can_vote_for(req->vclock)) {
>> say_info("RAFT: vote request is skipped - the "
>> - "leader is already known - %u",
>> - raft.leader);
>> + "vclock is not acceptable");
>> break;
>
>
> Are you sure we want these messages on `info` level? Info is the default log level and
>
> RAFT spams the log with quite a lot of messages. Maybe `verbose` level would be better?
Raft messages are supposed to be sent super rare. Only at an instance start, and when
the leader fails. They are sent often only in the tests, because we tweak Raft config
values a lot and start/kill instances. So I would keep these logs. They could help to
recover what happened in a live cluster if something goes wrong with Raft.
I propose to lower them to verbose or even remove in case someone will complain.
next prev parent reply other threads:[~2020-09-23 20:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 23:16 [Tarantool-patches] [PATCH v2 00/11] dRaft Vladislav Shpilevoy
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 01/11] applier: store instance_id in struct applier Vladislav Shpilevoy
2020-09-14 9:38 ` Serge Petrenko
2020-09-19 15:44 ` Vladislav Shpilevoy
2020-09-21 6:23 ` Serge Petrenko
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 10/11] raft: introduce box.info.raft Vladislav Shpilevoy
2020-09-14 9:42 ` Serge Petrenko
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 11/11] [tosquash] raft: a swarm of minor fixes Vladislav Shpilevoy
2020-09-14 10:13 ` Serge Petrenko
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 02/11] box: introduce summary RO flag Vladislav Shpilevoy
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 03/11] wal: don't touch box.cfg.wal_dir more than once Vladislav Shpilevoy
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 04/11] replication: track registered replica count Vladislav Shpilevoy
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 05/11] [wip] box: do not register outgoing connections Vladislav Shpilevoy
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 06/11] raft: introduce persistent raft state Vladislav Shpilevoy
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 07/11] raft: introduce box.cfg.raft_* options Vladislav Shpilevoy
2020-09-09 23:16 ` [Tarantool-patches] [PATCH v2 08/11] raft: relay status updates to followers Vladislav Shpilevoy
2020-09-20 17:17 ` Vladislav Shpilevoy
2020-09-21 7:13 ` Serge Petrenko
2020-09-21 10:50 ` Serge Petrenko
2020-09-21 22:47 ` Vladislav Shpilevoy
2020-09-22 8:48 ` Serge Petrenko
2020-09-21 22:47 ` Vladislav Shpilevoy
2020-09-22 8:47 ` Serge Petrenko
2020-09-09 23:17 ` [Tarantool-patches] [PATCH v2 09/11] raft: introduce state machine Vladislav Shpilevoy
2020-09-19 15:49 ` Vladislav Shpilevoy
2020-09-19 15:50 ` Vladislav Shpilevoy
2020-09-21 8:20 ` Serge Petrenko
2020-09-21 8:22 ` Serge Petrenko
2020-09-21 8:34 ` Serge Petrenko
2020-09-21 22:47 ` Vladislav Shpilevoy
2020-09-22 8:49 ` Serge Petrenko
2020-09-22 22:48 ` Vladislav Shpilevoy
2020-09-23 9:59 ` Serge Petrenko
2020-09-23 20:31 ` Vladislav Shpilevoy [this message]
2020-09-24 9:34 ` Serge Petrenko
2020-09-19 15:58 ` [Tarantool-patches] [PATCH v2 12/11] dRaft Vladislav Shpilevoy
2020-09-19 15:59 ` Vladislav Shpilevoy
2020-09-21 7:24 ` Serge Petrenko
2020-09-21 22:48 ` [Tarantool-patches] [PATCH v2 12/11] raft: add tests Vladislav Shpilevoy
2020-09-30 10:56 ` [Tarantool-patches] [PATCH v2 00/11] dRaft Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a655ceea-5862-4690-4e14-823ee7a9c8e6@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 09/11] raft: introduce state machine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox