Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: mechanik20051988 <mechanik20051988@tarantool.org>,
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/4] Choose allocator mor memtx
Date: Sun, 10 Jan 2021 14:55:39 +0100	[thread overview]
Message-ID: <a5868b37-5cd2-9984-8533-61f8a3ad809a@tarantool.org> (raw)
In-Reply-To: <cover.1609239402.git.mechanik20051988@tarantool.org>

Hi! Thanks for the patchset!

I didn't review the code yet. Only the commit messages. But already
can give some comments.

On 29.12.2020 12:03, mechanik20051988 via Tarantool-patches wrote:
> Branch: https://github.com/tarantool/tarantool/tree/mechanik20051988/gh-5419-choose-allocator-for-memtx-cpp-14
>         (Do not pay attention to the number 14 in the branch header)
> Issue: https://github.com/tarantool/tarantool/issues/5419
> Pull request: https://github.com/tarantool/tarantool/pull/5670
> About patches:
> 	1. First patch add performance test for memtx allocator. You can copy perf folder 
> 	to master branch and compare performance.
> 	2. Second patch convert some *.c files to *.cc files. 
> 	   This is the preparation for the patch with allocator choise
> 	3. Third patch implement api for allocator choise
> 	4. Fourth patch add system allocator based on malloc and free
> This is a completely redesigned patch, however I would like to provide answers 
> to some questions from the previous patch that may overlap
> 1. malloc_usable_size / malloc_size has different headers in different OS, so i use
>    TARGET_OS_*** to check this in source file not in CMakeLists
> 2. I test snapshot using checkpoint_interval=5 option, several snapshots
>    are created during my test

And I said in private that it not only makes the test run at least 5 seconds,
which is way too long. But also is not any different from calling box.snapshot()
manually. Please, use box.snapshot().

  parent reply	other threads:[~2021-01-10 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29 11:03 mechanik20051988
2020-12-29 11:03 ` [Tarantool-patches] [PATCH 1/4] test: add performance test for memtx allocator mechanik20051988
2020-12-29 11:03 ` [Tarantool-patches] [PATCH 2/4] memtx: changed some memtx files from .c to .cc mechanik20051988
2020-12-29 11:03 ` [Tarantool-patches] [PATCH 3/4] memtx: implement api for memory allocator selection mechanik20051988
2021-01-10 13:56   ` Vladislav Shpilevoy via Tarantool-patches
2020-12-29 11:03 ` [Tarantool-patches] [PATCH 4/4] Implement system allocator, based on malloc mechanik20051988
2021-01-10 13:56   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-10 13:55 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-01-10 14:36 ` [Tarantool-patches] [PATCH 0/4] Choose allocator mor memtx Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5868b37-5cd2-9984-8533-61f8a3ad809a@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alyapunov@tarantool.org \
    --cc=mechanik20051988@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/4] Choose allocator mor memtx' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox