From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C4E034C880; Sun, 10 Jan 2021 18:07:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C4E034C880 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610291224; bh=wA526dbUF9PJ4j83P7zcbOFkrmwrmn8dZEmrmcLQyOM=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ecZakvXKt3jF8O262p6YppU/p0x+cOE9z9oj85qv3asy3OjXYh2hm0ytM2YzNdBjt kReelrOfTSZmaR2Ng/58NB5geKvwA1mwg5pIIcbuvuuKHirePgclPkDzwb05LLIPnk 1QjjkC74Ih2kCUXMvr+gc+osJLv+aXDmHoy6cFAU= Received: from fallback24.mail.ru (fallback24.m.smailru.net [94.100.187.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 473904C880 for ; Sun, 10 Jan 2021 18:07:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 473904C880 Received: from [10.161.100.15] (port=41400 helo=smtpng3.m.smailru.net) by fallback24.m.smailru.net with esmtp (envelope-from ) id 1kybC1-0008D3-O0 for tarantool-patches@dev.tarantool.org; Sun, 10 Jan 2021 16:55:42 +0300 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1kybC0-0005se-Lt; Sun, 10 Jan 2021 16:55:41 +0300 To: mechanik20051988 , alyapunov@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: Date: Sun, 10 Jan 2021 14:55:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CDAC53986DC5FB1AB1465E8C05863AF8B800894C459B0CD1B911BAAAA98C8CD9A394D79E5A28C37C8F941F610704505C2D7CBF1C18CED4D92F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FACF2191C0719DEE8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCFFDE1474D19ACA27ED3D2A753AB68760654203DDBB57C2EF389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C01EC9944F70C6CA998941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B68424CA1AAF98A6958941B15DA834481F9449624AB7ADAF3735872C767BF85DA29E625A9149C048EE0A3850AC1BE2E73579C543ECCDAE434E4AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8BE0F7FC12A719E3B775ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57E8FBB06288C1946000306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5C338B9194E5D9A5A22D7FF9A286932EDBC49FB149B8CBC19D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75B7BFB303F1C7DB4D8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AEC7C2AC3C44791DC92F02B1000E49F4A95A6A50ED1E18C69E9E7B7E87A8623C892BEE72F5EB8E8D1D7E09C32AA3244C070F5A0B967519568BDB1188E9E96C4FBBA718C7E6A9E042FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrM+fB0klCkYK/kq75Irmtg== X-Mailru-Sender: 689FA8AB762F73937240DDB2502DDB7094088FB4E0AB3AAA11970A774D259CCF3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok X-7564579A: 646B95376F6C166E X-77F55803: 6242723A09DB00B40E5D90E44ABF6C6604BA033ECC7B62DEFF58D7CC134EE095049FFFDB7839CE9E8C4BD7E8152C928B0D3C58532B23E94970E19CBE0730BDE3B29050E31DC09D77 X-7FA49CB5: 0D63561A33F958A597550F1B27F454EA8CB32D52A125054E096C15D2BEFCC9ED8941B15DA834481FA18204E546F3947C5DA91C8160F4BAA0F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006374DED0A6FD11BC3B8389733CBF5DBD5E9B5C8C57E37DE458BD96E472CDF7238E04AD6D5ED66289B5278DA827A17800CE7AAF33752BA76F86767F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C31C82795A95DEC3B035872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C934F12F0C005D1A85E5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A597550F1B27F454EA8CB32D52A125054E4E4EA0E13767B72AD59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrM+fB0klCka6NvWDPfovRg== X-Mailru-MI: 800 X-Mailru-Sender: A5480F10D64C90052060E016933BC039E880868FE4FDA7619BEE0C131045E07993C0C812F0D48D8A841FB911095AA09146E8006E22572C39C920B61C43410E8717BDA556287159EE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/4] Choose allocator mor memtx X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patchset! I didn't review the code yet. Only the commit messages. But already can give some comments. On 29.12.2020 12:03, mechanik20051988 via Tarantool-patches wrote: > Branch: https://github.com/tarantool/tarantool/tree/mechanik20051988/gh-5419-choose-allocator-for-memtx-cpp-14 > (Do not pay attention to the number 14 in the branch header) > Issue: https://github.com/tarantool/tarantool/issues/5419 > Pull request: https://github.com/tarantool/tarantool/pull/5670 > About patches: > 1. First patch add performance test for memtx allocator. You can copy perf folder > to master branch and compare performance. > 2. Second patch convert some *.c files to *.cc files. > This is the preparation for the patch with allocator choise > 3. Third patch implement api for allocator choise > 4. Fourth patch add system allocator based on malloc and free > > This is a completely redesigned patch, however I would like to provide answers > to some questions from the previous patch that may overlap > > 1. malloc_usable_size / malloc_size has different headers in different OS, so i use > TARGET_OS_*** to check this in source file not in CMakeLists > 2. I test snapshot using checkpoint_interval=5 option, several snapshots > are created during my test And I said in private that it not only makes the test run at least 5 seconds, which is way too long. But also is not any different from calling box.snapshot() manually. Please, use box.snapshot().