Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] fiber: extend max fiber name length to 255
Date: Mon, 16 Mar 2020 23:29:31 +0100	[thread overview]
Message-ID: <a49916bb-2375-e126-d6c7-bb1147b6e229@tarantool.org> (raw)
In-Reply-To: <20200316124817.GA14628@tarantool.org>

Indeed. Ask everyone to add them, and forgot myself.

@ChangeLog
- Fiber.name maximal length is extended to 255 (gh-4394).

On 16/03/2020 13:48, Nikita Pettik wrote:
> On 15 Mar 16:11, Vladislav Shpilevoy wrote:
>> Users keep complaining about too short fiber name. New limit is
>> 255, should be enough for any sane name.
>>
>> Closes #4394
>>
>> @TarantoolBot document
>> Title: fiber.name length limit.
>>
>> It was 32, now it is 255. Besides, it seems like `fiber.name`
>> `{truncate = true}` option is not documented.
>>
>> By default, if a new name is too long, `fiber.name(new_name)`
>> fails with an exception. To make it always succeed there is an
>> option 'truncate': `fiber.name(new_name, {truncate = true})`. It
>> truncates the name to the max length if it is too long.
>> ---
>> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4394-fiber-name-inline
>> Issue: https://github.com/tarantool/tarantool/issues/4394
>>
>> Changes in v2:
>> - Short fiber names are kept inside struct fiber.
>>
> 
> LGTM. Seems you forgot to add changelog for github release.
>  
> 

  reply	other threads:[~2020-03-16 22:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15 15:11 Vladislav Shpilevoy
2020-03-16  7:19 ` Cyrill Gorcunov
2020-03-16 22:28   ` Vladislav Shpilevoy
2020-03-16 22:31     ` Cyrill Gorcunov
2020-03-16 12:48 ` Nikita Pettik
2020-03-16 22:29   ` Vladislav Shpilevoy [this message]
2020-03-18 21:35 ` Vladislav Shpilevoy
2020-03-18 23:57   ` Nikita Pettik
2020-03-19 22:30     ` Vladislav Shpilevoy
2020-03-20  1:59       ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a49916bb-2375-e126-d6c7-bb1147b6e229@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 1/1] fiber: extend max fiber name length to 255' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox