From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn: don't trust group id in remote request header
Date: Tue, 21 Jan 2020 21:34:39 +0100 [thread overview]
Message-ID: <a46ab95c-1ce1-9609-ef3d-e90db57d89b5@tarantool.org> (raw)
In-Reply-To: <20200121123930.5cuaj4j6ypfpsvlo@tarantool.org>
So, you decided not to push it into 1.10? Why? The bug
affects 1.10 as well.
On 21/01/2020 13:39, Kirill Yukhin wrote:
> Hello,
>
> On 15 янв 22:24, Vladislav Shpilevoy wrote:
>> Transaction adds a redo log for each statement. The log is an xrow
>> header. Some requests don't have a header (local requests), some
>> do (from remote client, from replication).
>>
>> When a request had a header, it was written as is to WAL. But
>> requests from remote client have an xrow header, however barely
>> filled. Most of its fields are default values, usually 0.
>> Including group id. Indeed, remote clients should not care about
>> setting such deep system fields.
>>
>> That led to a problem when a space had group id local (!= 0), but
>> it was ignored because in a request header from a remote client
>> the group id was default (== 0). On the summary, it was possible
>> to force Tarantool to replicate a replica-local space.
>>
>> Now group id setting is server-authoritative. Box always sets it
>> regardless of what is present in an xrow header received from a
>> client.
>>
>> Thanks Kostja Osipov (@kostja) for the diagnostics and the
>> solution.
>>
>> Closes #4729
>
> I've checked your patch into 2.2, 2.3 and master.
>
> --
> Regards, Kirill Yukhin
>
next prev parent reply other threads:[~2020-01-21 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 21:24 Vladislav Shpilevoy
2020-01-16 19:40 ` Georgy Kirichenko
2020-01-21 12:39 ` Kirill Yukhin
2020-01-21 20:34 ` Vladislav Shpilevoy [this message]
2020-01-23 6:55 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46ab95c-1ce1-9609-ef3d-e90db57d89b5@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] txn: don'\''t trust group id in remote request header' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox