Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] ASAN build
Date: Tue, 16 Jun 2020 00:21:13 +0200	[thread overview]
Message-ID: <a2f7e99b-b264-c304-47cd-42e625261974@tarantool.org> (raw)
In-Reply-To: <20200615140142.jgeryiqpfnhdxs55@tkn_work_nb>

Hi!

On 15/06/2020 16:01, Alexander Turenko wrote:
> LGTM except broken coverage reporting:
> 
> https://travis-ci.org/github/tarantool/tarantool/jobs/698246927
> 
> It looks quite similar to
> https://github.com/tarantool/tarantool/commit/415c05868f95b45a56904d5aa581358aced05efe
> 
> Maybe we should add '-o ${CMAKE_BINARY_DIR}/src/box/sql/parse.c' to
> lemon call to write absolute path in #line directives, which may help to
> avoid ambiguity.

Thanks for noticing and for the proposed fix. I did this:

-    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c ${SQL_SRC_DIR}/parse.y
+    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c -o${SQL_BIN_DIR}/parse ${SQL_SRC_DIR}/parse.y

Now parse.c contains absolute paths in #line directives. But I couldn't
wait if it helped - travis is awfully slow. Lets see if it helped tomorrow,
when the job will be finally done.

  reply	other threads:[~2020-06-15 22:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14 16:24 Vladislav Shpilevoy
2020-06-14 16:24 ` [Tarantool-patches] [PATCH 1/2] sql: don't build sql as a separate library Vladislav Shpilevoy
2020-06-15 15:42   ` Timur Safin
2020-06-14 16:24 ` [Tarantool-patches] [PATCH 2/2] cmake: split UB sanitations into separate flags Vladislav Shpilevoy
2020-06-15 15:41   ` Timur Safin
2020-06-15 22:19     ` Vladislav Shpilevoy
2020-06-15 14:01 ` [Tarantool-patches] [PATCH 0/2] ASAN build Alexander Turenko
2020-06-15 22:21   ` Vladislav Shpilevoy [this message]
2020-06-15 23:04     ` Alexander Turenko
2020-06-15 23:15       ` Vladislav Shpilevoy
2020-06-15 15:43 ` Timur Safin
2020-06-16  8:56 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2f7e99b-b264-c304-47cd-42e625261974@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] ASAN build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox