From: lvasiliev <lvasiliev@tarantool.org>
To: imun@tarantool.org
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Fix some options of rocks module
Date: Thu, 2 Apr 2020 10:35:58 +0300 [thread overview]
Message-ID: <a176e6de-24df-1eab-13b3-6a7e499e62fc@tarantool.org> (raw)
In-Reply-To: <20200401113307.GR22874@tarantool.org>
Hi, thanks for the review.
On 01.04.2020 14:33, Igor Munkin wrote:
> Leonid,
>
> Thanks for the series! Considering your post-review fixups and omitting
> other comments I have regarding the tarantoolctl code, it LGTM.
>
> Please add a ChangeLog entry for your patchset.
Done
(https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4529-fix-show-all)
@Changelog
Fixed the tarantoolctl rocks search flag --all
and
@Changelog
Fixed the tarantoolctl rocks remove flag --force
>
> Sasha, please proceed with the series.
>
> On 16.03.20, Leonid Vasiliev wrote:
>> https://github.com/tarantool/tarantool/issues/3632
>> https://github.com/tarantool/tarantool/issues/4529
>> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4529-fix-show-all
>>
>> Some new options (--all and --force) have been added to the white-list for forwarding to the tarantoolctl rocks module.
>>
>> Leonid (2):
>> luarocks: Add a kludge for option all of luarocks search
>> luarocks: Add a kludge for option force of luarocks remove
>>
>> extra/dist/tarantoolctl.in | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> --
>> 2.17.1
>>
>
next prev parent reply other threads:[~2020-04-02 7:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 11:50 Leonid Vasiliev
2020-03-16 11:50 ` [Tarantool-patches] [PATCH v2 1/2] luarocks: Add a kludge for option all of luarocks search Leonid Vasiliev
2020-03-16 12:01 ` Leonid Vasiliev
2020-03-31 23:21 ` Igor Munkin
2020-04-01 10:00 ` lvasiliev
2020-04-02 15:50 ` lvasiliev
2020-03-16 11:50 ` [Tarantool-patches] [PATCH v2 2/2] luarocks: Add a kludge for option force of luarocks remove Leonid Vasiliev
2020-03-31 23:21 ` Igor Munkin
2020-04-01 10:02 ` lvasiliev
2020-04-02 15:52 ` lvasiliev
2020-03-18 22:34 ` [Tarantool-patches] [PATCH v2 0/2] Fix some options of rocks module Vladislav Shpilevoy
2020-03-19 19:19 ` Igor Munkin
2020-04-01 11:33 ` Igor Munkin
2020-04-02 7:35 ` lvasiliev [this message]
2020-04-02 15:34 ` Kirill Yukhin
2020-04-09 1:00 ` Alexander Turenko
2020-04-04 18:40 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a176e6de-24df-1eab-13b3-6a7e499e62fc@tarantool.org \
--to=lvasiliev@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] Fix some options of rocks module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox