Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove temporary box_iterator_key_def
Date: Thu, 17 May 2018 18:05:15 +0300	[thread overview]
Message-ID: <a147ec3a-9325-0638-d57b-09bda64c3e89@tarantool.org> (raw)
In-Reply-To: <98d8572affd09ca99e92f29e90165ca29f664847.1526564450.git.kyukhin@tarantool.org>

Hello. Thanks for the patch!

On 17/05/2018 16:41, Kirill Yukhin wrote:
> It is possible to extract key_def from iterator directly
> in SQL FE. So, no need in any temporary API hacks anymore.
> The patch removes this API function and replaces its calls
> w/ direct field access in SQL FE.
> 
> Closes #2425
> ---

1. Please, post branch and issue links here.

2. I can not find any branch with 2425 in name.

The patch LGTM.

  reply	other threads:[~2018-05-17 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 13:41 [tarantool-patches] " Kirill Yukhin
2018-05-17 15:05 ` Vladislav Shpilevoy [this message]
2018-05-17 16:03   ` [tarantool-patches] " Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a147ec3a-9325-0638-d57b-09bda64c3e89@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: remove temporary box_iterator_key_def' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox