From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 0/5] Replace control pragmas by SET
Date: Sat, 19 Oct 2019 00:08:13 +0200 [thread overview]
Message-ID: <a0dab619-14b5-74c7-6015-1261758a3859@tarantool.org> (raw)
In-Reply-To: <cover.1571322776.git.imeevma@gmail.com>
Hi! Thanks for the patchset!
Mostly the design is ok. Consider a question below.
What about having a more general settings space? For all
session settings. Named like '_vsession_settings'. Or
'_vsession_storage'. It will be exactly like in your
patchset, but all SQL settings will have 'sql_' prefix.
And then we could reuse that space for other settings,
even from not SQL, like Kostja planned.
I am just afraid, that number of system spaces grows
without a control. With current pace we have only 16
free IDs left for system spaces. Next are user space.
See, now we've used 380. The last is 511. Interval is 8.
131 / 8 = 16. And we can't put them tighter. We
need 8-width gaps to be able to insert new spaces
between existing ones when a certain recovery order will
be needed.
16 is not really many, taking into account a pile of
information schema views going to be added.
On 17/10/2019 16:40, imeevma@tarantool.org wrote:
> This patch0set created a new SQL command: SET. This command is
> used to change SQL settings, including debugging settings.
>
> The main goal of this fix pack version is to choose a design to
> solve the problem.
>
> https://github.com/tarantool/tarantool/issues/4511
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4511-pragma-replaced-by-set
>
prev parent reply other threads:[~2019-10-18 22:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 14:40 [Tarantool-patches] " imeevma
2019-10-17 14:40 ` [Tarantool-patches] [PATCH v1 1/5] sysview: make get() and create_iterator() methods virtual imeevma
2019-10-17 14:40 ` [Tarantool-patches] [PATCH v1 2/5] box: introduce _vsql_settings sysview imeevma
2019-10-18 22:08 ` [Tarantool-patches] [tarantool-patches] " Vladislav Shpilevoy
2019-10-17 14:40 ` [Tarantool-patches] [PATCH v1 3/5] sql: create SET command imeevma
2019-10-18 22:08 ` [Tarantool-patches] [tarantool-patches] " Vladislav Shpilevoy
2019-10-17 14:40 ` [Tarantool-patches] [PATCH v1 4/5] temporary: disable boolean.test.sql imeevma
2019-10-17 14:40 ` [Tarantool-patches] [PATCH v1 5/5] sql: replace control pragmas imeevma
2019-10-18 22:08 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0dab619-14b5-74c7-6015-1261758a3859@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 0/5] Replace control pragmas by SET' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox