Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: kostja@tarantool.org
Subject: [tarantool-patches] [PATCH 1/5] swim: fix flaky 'indirect pings' test
Date: Thu,  4 Jul 2019 01:28:30 +0200	[thread overview]
Message-ID: <a0af421619d5dc46c1f601af188007d46dce2a85.1562196102.git.v.shpilevoy@tarantool.org> (raw)
In-Reply-To: <cover.1562196102.git.v.shpilevoy@tarantool.org>

With a certain random seed sometimes a member was checked for a
status in a wrong moment of time.
---
 test/unit/swim.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/unit/swim.c b/test/unit/swim.c
index 349c3312e..d93f80554 100644
--- a/test/unit/swim.c
+++ b/test/unit/swim.c
@@ -892,9 +892,9 @@ swim_test_indirect_ping(void)
 	swim_cluster_set_drop_channel(cluster, 0, 1, true);
 	swim_cluster_set_drop_channel(cluster, 1, 0, true);
 	swim_run_for(10);
-	is(swim_cluster_wait_status_everywhere(cluster, 0, MEMBER_ALIVE, 0),
+	is(swim_cluster_wait_status_everywhere(cluster, 0, MEMBER_ALIVE, 3),
 	   0, "S1 is still alive everywhere");
-	is(swim_cluster_wait_status_everywhere(cluster, 1, MEMBER_ALIVE, 0),
+	is(swim_cluster_wait_status_everywhere(cluster, 1, MEMBER_ALIVE, 3),
 	   0, "as well as S2 - they communicated via S3");
 
 	swim_cluster_delete(cluster);
-- 
2.20.1 (Apple Git-117)

  reply	other threads:[~2019-07-03 23:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03 23:28 [tarantool-patches] [PATCH 0/5] SWIM loglog preparation Vladislav Shpilevoy
2019-07-03 23:28 ` Vladislav Shpilevoy [this message]
2019-07-04  8:20   ` [tarantool-patches] Re: [PATCH 1/5] swim: fix flaky 'indirect pings' test Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 2/5] swim: sadly remove cache Vladislav Shpilevoy
2019-07-04  8:22   ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 3/5] test: redo some swim tests using error injections Vladislav Shpilevoy
2019-07-04  8:23   ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 4/5] swim: speed-up tests Vladislav Shpilevoy
2019-07-04  8:24   ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 5/5] swim: speed-up empty payloads cluster bootstrap Vladislav Shpilevoy
2019-07-04  8:26   ` [tarantool-patches] " Konstantin Osipov
2019-07-05 22:44 ` [tarantool-patches] Re: [PATCH 0/5] SWIM loglog preparation Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0af421619d5dc46c1f601af188007d46dce2a85.1562196102.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 1/5] swim: fix flaky '\''indirect pings'\'' test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox