Re: [Tarantool-patches] [PATCH v3 luajit 1/2] cmake: run tests with Valgrind

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On 14.11.24, Sergey Kaplun via Tarantool-patches wrote:
> Hi, Maksim!
> Thanks for the patch!
> Please consider my comments below.
> 
> On 11.11.24, mandesero@gmail.com wrote:

<snipped>

> >   - test/tarantool-tests/lj-512-profiler-hook-finalizers.test.lua
> >   - test/tarantool-tests/lj-726-profile-flush-close.test.lua
> >   - test/tarantool-tests/misclib-sysprof-lapi.test.lua

I also get the following error locally:

| test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua (SIGPROF)

So, it looks like all sysprof's tests should be disabled.

> > 
> > Timed out due to running under Valgrind:
> >   - test/tarantool-tests/gh-7745-oom-on-trace.test.lua
> >   - test/tarantool-tests/lj-1034-tabov-error-frame.test.lua
> > 

Also, I've found that tests from LuaJIT-tests suite reports tons of the
assertions, but still the suite passes. This should be fixed:

I suppose that we need to set `--error-exitcode` option as well.

The option `--exit-on-first-error` may be also considered.

| ctest --verbose -L LuaJIT-tests
| ...
| 2: ==20374== Command: /home/burii/reviews/luajit/valgrind-ci/src/luajit -e dofile[[/home/burii/reviews/luajit/valgrind-ci/test/luajit-test-init.lua]] /home/burii/reviews/luajit/valgrind-ci/test/LuaJIT-tests/test.lua +slow +ffi +bit +jit
| 2: ==20374==
| 2: ==20374== Invalid read of size 4
| 2: ==20374==    at 0x137059: lj_getu32 (lj_def.h:244)

Same for PUC-Rio-Lua-5.1-tests, lua-Harness-test.
Also, I see these warnings for tarantool-tests suite as well, see
| ctest --verbose -R test/tarantool-tests/fix-jit-dump-ir-conv.test.lua
for example:
| 82: ==25641== Conditional jump or move depends on uninitialised value(s)
| 82: ==25641==    at 0x1BCD8F: lj_BC_ADDVN (/home/burii/reviews/luajit/valgrind-ci/src/lj_vm.S:252)
| 82: ==25641==    by 0x1445F3: lj_vmevent_call (lj_vmevent.c:46)
| 82: ==25641==    by 0x186EB5: trace_stop (lj_trace.c:555)
| 82: ==25641==    by 0x184422: trace_state (lj_trace.c:726)
| 82: ==25641==    by 0x1BE97D: lj_vm_cpcall (/home/burii/reviews/luajit/valgrind-ci/src/lj_vm.S:1266)
| 82: ==25641==    by 0x183CA1: lj_trace_ins (lj_trace.c:757)
| 82: ==25641==    by 0x1263C4: lj_dispatch_ins (lj_dispatch.c:430)
| 82: ==25641==    by 0x1C0D69: lj_vm_inshook (/home/burii/reviews/luajit/valgrind-ci/src/lj_vm.S:2649)
| 82: ==25641==    by 0x11FCCA: lua_pcall (lj_api.c:1173)
| 82: ==25641==    by 0x112A84: docall (luajit.c:133)
| 82: ==25641==    by 0x112620: handle_script (luajit.c:304)
| 82: ==25641==    by 0x111B9C: pmain (luajit.c:604)

Also, I confused with the Command content,
It looks like the valgrind with its options is missed.

Also, it would be nice to run all tarantool-c-tests under valgrind.

Also, what do you think about enabling option `--track-fds` for the CI
(maybe in the separate patch set).

-- 
Best regards,
Sergey Kaplun