[Tarantool-patches] [PATCH luajit] test: off JIT for routines in <lang/stackov.lua>

[Tarantool-patches] [PATCH luajit] test: off JIT for routines in <lang/stackov.lua>

[Sergey Kaplun via Tarantool-patches]

This patch is a follow-up to the commit
6a3a97cd8111a2164143fcf81439f70588e0be42 ("test: enable
<misc/stackovc.lua> LuaJIT test"). The enabled test may raise an error
for the specific builds (see [1], for example) when the stack overflow
error is raised on the trace exit during the restoration from the
snapshot. In that case, LuaJIT VM can't restore the full traceback, and
the corresponding check in the test is failed.

This patch disables JIT for these functions with recursive calls to
avoid such failures.

[1]: https://github.com/tarantool/luajit/actions/runs/10717386746

Follows up #9398
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/follow-up-fix-gh-9398-p2

 test/LuaJIT-tests/lang/stackov.lua | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test/LuaJIT-tests/lang/stackov.lua b/test/LuaJIT-tests/lang/stackov.lua
index 21ae40b6..8afa86b4 100644
--- a/test/LuaJIT-tests/lang/stackov.lua
+++ b/test/LuaJIT-tests/lang/stackov.lua
@@ -1,18 +1,22 @@
 local function f()
   f()
 end
+jit.off(f)
 
 local function g(i)
   g(i)
 end
+jit.off(g)
 
 local function vtail(...)
   return vtail(1, ...)
 end
+jit.off(vtail)
 
 local function vcall(...)
   vcall(1, ...)
 end
+jit.off(vcall)
 
 local function test_error_msg(func, s)
   local first = string.match(s, "[^\n]+")
-- 
2.46.0

Re: [Tarantool-patches] [PATCH luajit] test: off JIT for routines in <lang/stackov.lua>

[Maxim Kokryashkin via Tarantool-patches]

Hi, Sergey!
Thanks for the patch!
LGTM

Re: [Tarantool-patches] [PATCH luajit] test: off JIT for routines in <lang/stackov.lua>

[Sergey Bronnikov via Tarantool-patches]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

Hi, Sergey!

On 05.09.2024 13:14, Sergey Kaplun wrote:
> This patch is a follow-up to the commit
> 6a3a97cd8111a2164143fcf81439f70588e0be42 ("test: enable
> <misc/stackovc.lua> LuaJIT test"). The enabled test may raise an error
> for the specific builds (see [1], for example) when the stack overflow
> error is raised on the trace exit during the restoration from the
> snapshot. In that case, LuaJIT VM can't restore the full traceback, and
> the corresponding check in the test is failed.
>
> This patch disables JIT for these functions with recursive calls to
> avoid such failures.
>
> [1]:https://github.com/tarantool/luajit/actions/runs/10717386746
>
> Follows up #9398
> ---

Thanks for the patch! LGTM

<snipped>

[-- Attachment #2: Type: text/html, Size: 1289 bytes --]

Re: [Tarantool-patches] [PATCH luajit] test: off JIT for routines in <lang/stackov.lua>

[Sergey Kaplun via Tarantool-patches]

I've applied the patch into all long-term branches in tarantool/luajit
and bumped a new version in master [1], release/3.2 [2] and
release/2.11 [3].

[1]: https://github.com/tarantool/tarantool/pull/10712
[2]: https://github.com/tarantool/tarantool/pull/10713
[3]: https://github.com/tarantool/tarantool/pull/10714

-- 
Best regards,
Sergey Kaplun