From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix misclib-getmetrics-lapi.test.lua
Date: Tue, 15 Oct 2024 10:40:06 +0300 [thread overview]
Message-ID: <Zw4cVkMxnHTJqoop@root> (raw)
In-Reply-To: <busi5diyihzptadfaol2ilyxslkuxc4z67inwf6zffy2xlm7od@f656wb5k2ycs>
Hi, Maxim!
Thanks for the review!
I fixed your comment, rebased branch to the current master, and
force-pushed it.
On 11.10.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a single nit regarding the commit message:
>
> On Sat, Sep 28, 2024 at 01:33:59PM GMT, Sergey Kaplun wrote:
> > When run under Tarantool, the test may fail if Tarantool already has
> > performed some finalize steps. This patch fixes it by making the test
> > more general.
> > ---
>
> IMO, it would be more readable to paraphrase like:
> | When executed in Tarantool, the test might fail if Tarantool has
> | already completed certain finalization steps. This patch
> | addresses the issue by making the test more adaptable.
>
> <snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2024-10-15 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 10:33 Sergey Kaplun via Tarantool-patches
2024-10-01 9:42 ` Sergey Bronnikov via Tarantool-patches
2024-10-11 18:51 ` Maxim Kokryashkin via Tarantool-patches
2024-10-15 7:40 ` Sergey Kaplun via Tarantool-patches [this message]
2024-10-18 15:19 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw4cVkMxnHTJqoop@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: fix misclib-getmetrics-lapi.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox