From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 luajit 7/7] test: set LD_PRELOAD only when necessary Date: Tue, 24 Sep 2024 18:23:55 +0300 [thread overview] Message-ID: <ZvLZi0UQlZTSyHU2@root> (raw) In-Reply-To: <1d07cc3d-10b4-4ea4-8d71-421b4f6e0c95@tarantool.org> Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 24.09.24, Sergey Bronnikov wrote: > Hi, Sergey, > > On 24.09.2024 13:29, Sergey Kaplun wrote: > > This patch sets LD_PRELOAD for ASan build for the required tests instead > > of all tests. > > > > Follows up tarantool/tarantool#9898 > > probably follows up these commits as well: > > > commit 9f1137bcc890c28c5de24497624553574d371007 "cmake: replace prove > with CTest" > > commit abe1e0aca3ad01f89f9d184c2a82949314814d04 "ci: execute LuaJIT > tests with GCC 10 and ASAN" I've opted the previous commit (where the corresponding FIXME is introduced). The new commit message is: | test: set LD_PRELOAD only when necessary | | As a follow-up for 888adcfb72e361b150a9038407eb1dc9bd3392bd ("test: fix | lj-802-panic-at-mcode-protfail GCC+ASan"), this patch sets LD_PRELOAD | for ASan build for the required tests instead of all tests. | | Follows up tarantool/tarantool#9898 > > LGTM > > > --- <snipped> -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2024-09-24 15:24 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-09-24 10:29 [Tarantool-patches] [PATCH v2 luajit 0/7] Shrink test env and fix flaky tests Sergey Kaplun via Tarantool-patches 2024-09-24 10:29 ` [Tarantool-patches] [PATCH v2 luajit 1/7] test: move profilers tests to subdirectory Sergey Kaplun via Tarantool-patches 2024-09-24 11:07 ` Sergey Bronnikov via Tarantool-patches 2024-10-11 18:28 ` Maxim Kokryashkin via Tarantool-patches 2024-09-24 10:29 ` [Tarantool-patches] [PATCH v2 luajit 2/7] test: rename <arm64-ccall-fp-convention.test.lua> Sergey Kaplun via Tarantool-patches 2024-09-24 11:07 ` Sergey Bronnikov via Tarantool-patches 2024-10-11 18:29 ` Maxim Kokryashkin via Tarantool-patches 2024-09-24 10:29 ` [Tarantool-patches] [PATCH v2 luajit 3/7] cmake: introduce AppendTestEnvVar macro Sergey Kaplun via Tarantool-patches 2024-09-24 11:07 ` Sergey Bronnikov via Tarantool-patches 2024-10-11 18:30 ` Maxim Kokryashkin via Tarantool-patches 2024-09-24 10:29 ` [Tarantool-patches] [PATCH v2 luajit 4/7] test: shrink LUA_PATH environment variable Sergey Kaplun via Tarantool-patches 2024-09-24 11:15 ` Sergey Bronnikov via Tarantool-patches 2024-09-24 11:33 ` Sergey Kaplun via Tarantool-patches [not found] ` <ZvO5g6ryIcyhM1vg@root> 2024-09-25 7:22 ` Sergey Bronnikov via Tarantool-patches 2024-10-11 18:31 ` Maxim Kokryashkin via Tarantool-patches 2024-09-24 10:29 ` [Tarantool-patches] [PATCH v2 luajit 5/7] test: shrink LUA_CPATH and {DY}LD_LIBRARY_PATH Sergey Kaplun via Tarantool-patches 2024-09-24 11:16 ` Sergey Bronnikov via Tarantool-patches 2024-09-24 11:28 ` Sergey Kaplun via Tarantool-patches 2024-09-24 14:18 ` Sergey Bronnikov via Tarantool-patches 2024-10-11 18:37 ` Maxim Kokryashkin via Tarantool-patches 2024-10-12 7:00 ` Sergey Kaplun via Tarantool-patches 2024-09-24 10:29 ` [Tarantool-patches] [PATCH v2 luajit 6/7] test: skip flaky tests with enabled table bump Sergey Kaplun via Tarantool-patches 2024-09-24 11:26 ` Sergey Bronnikov via Tarantool-patches 2024-09-24 11:45 ` Sergey Kaplun via Tarantool-patches 2024-09-24 14:17 ` Sergey Bronnikov via Tarantool-patches 2024-10-11 18:38 ` Maxim Kokryashkin via Tarantool-patches 2024-09-24 10:29 ` [Tarantool-patches] [PATCH v2 luajit 7/7] test: set LD_PRELOAD only when necessary Sergey Kaplun via Tarantool-patches 2024-09-24 14:13 ` Sergey Bronnikov via Tarantool-patches 2024-09-24 15:23 ` Sergey Kaplun via Tarantool-patches [this message] 2024-09-24 17:41 ` Sergey Bronnikov via Tarantool-patches 2024-10-11 18:46 ` Maxim Kokryashkin via Tarantool-patches 2024-10-18 15:18 ` [Tarantool-patches] [PATCH v2 luajit 0/7] Shrink test env and fix flaky tests Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZvLZi0UQlZTSyHU2@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 luajit 7/7] test: set LD_PRELOAD only when necessary' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox