Re: [Tarantool-patches] [PATCH v2 luajit 4/7] test: shrink LUA_PATH environment variable

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!

On 24.09.24, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> 
> On 24.09.2024 13:29, Sergey Kaplun wrote:
> > This patch removes the default adding of the tools directory to the
> > LUA_PATH. Now it is done only for profilers tests.
> >
> > Part of tarantool/tarantool#9898
> > ---

<snipped>

> > @@ -163,4 +161,12 @@ foreach(test_path ${tests})
> >       LABELS ${TEST_SUITE_NAME}
> >       DEPENDS tarantool-tests-deps
> >     )
> > +
> > +  # The part of the profilers toolchain is located in the <tools/>
> > +  # directory, so LUA_PATH needs to be updated.
> > +  if(test_name MATCHES "^profilers")
> > +    AppendTestEnvVar(${test_title}
> > +      LUA_PATH "${PROJECT_SOURCE_DIR}/tools/?.lua\;"
> > +    )
> > +  endif()
> >   endforeach()
> 
> AFAIR, we decided to move the last hunk to profilers/CMakeLists.txt.

I don't remember that, unfortunately. Also, may be it is better that
this cycle handles all tests? Otherwise, we should scan that directory
again with constructing test_title again. This is why we decided to move
it in the cycle instead of the child <CMakeLists.txt> [1].

> 

[1]: https://lists.tarantool.org/tarantool-patches/c22c7bc2-ddaa-4b22-83ae-edba3ce73dd6@tarantool.org/T/#u

-- 
Best regards,
Sergey Kaplun