Re: [Tarantool-patches] [PATCH luajit] Add missing coercion when recording select(string, ...)

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 24.09.24, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch!
> 
> See minor comment below.
> 
> LGTM
> 
> 
> On 23.09.2024 14:28, Sergey Kaplun wrote:

<snipped>

> > +
> > +test:is(result, 1, 'corect select result after recording')
> 
> s/corect/correct/

Fixed, thanks!

===================================================================
diff --git a/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test.lua b/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test.
lua
index 8089247f..5145efd5 100644
--- a/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test.lua
+++ b/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test.lua
@@ -34,6 +34,6 @@ jit.opt.start('hotloop=1')
 -- XXX: amount of arguments is empirical, see the comment above.
 local result = test_select(1, 2, 3, 4)
 
-test:is(result, 1, 'corect select result after recording')
+test:is(result, 1, 'correct select result after recording')
 
 test:done(true)
===================================================================

> 
> 
> > +
> > +test:done(true)

-- 
Best regards,
Sergey Kaplun