From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 6/7] test: skip flaky tests with enabled table bump
Date: Mon, 23 Sep 2024 14:08:51 +0300 [thread overview]
Message-ID: <ZvFMQ-Gnzsq7uAz5@root> (raw)
In-Reply-To: <6a4831ef-22c0-428e-8e61-d8d394cd0939@tarantool.org>
Hi, Sergey!
Thanks for the review!
Please, consider my answer below.
On 23.09.24, Sergey Bronnikov wrote:
> Hi, Sergey!
>
> thanks for the patch!
>
> I would add our own issue as a reminder instead of LuaJIT issue
>
> and link them to each other.
I suppose this is excess since the Tarantool isn't affected (since we
don't enable table bump optimization due to the known issues with it).
Also, it is not clear when we can take this issue to work (and even will
we or not).
At the same time, the original issue is referenced. But even then, we
don't know if Mike has any plans for it or if this optimization will
just be dropped anyway in v3.0.
>
> On 23.09.2024 10:18, Sergey Kaplun wrote:
> > Profilers tests with LUAJIT_ENABLE_TABLE_BUMP are flaky due to the bug
> > in the TDUP patching. Disable them for now.
> > ---
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2024-09-23 11:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 7:18 [Tarantool-patches] [PATCH luajit 0/7] Shrink test env and fix flaky tests Sergey Kaplun via Tarantool-patches
2024-09-23 7:18 ` [Tarantool-patches] [PATCH luajit 1/7] test: move profilers tests to subdirectory Sergey Kaplun via Tarantool-patches
2024-09-23 7:40 ` Sergey Bronnikov via Tarantool-patches
2024-09-23 7:51 ` Sergey Kaplun via Tarantool-patches
2024-09-23 7:18 ` [Tarantool-patches] [PATCH luajit 2/7] test: rename <arm64-ccall-fp-convention.test.lua> Sergey Kaplun via Tarantool-patches
2024-09-23 7:45 ` Sergey Bronnikov via Tarantool-patches
2024-09-23 7:18 ` [Tarantool-patches] [PATCH luajit 3/7] cmake: introduce AppendTestEnvVar macro Sergey Kaplun via Tarantool-patches
2024-09-23 7:51 ` Sergey Bronnikov via Tarantool-patches
2024-09-23 8:18 ` Sergey Kaplun via Tarantool-patches
2024-09-23 7:18 ` [Tarantool-patches] [PATCH luajit 4/7] test: shrink LUA_PATH environment variable Sergey Kaplun via Tarantool-patches
2024-09-23 8:47 ` Sergey Bronnikov via Tarantool-patches
2024-09-23 7:18 ` [Tarantool-patches] [PATCH luajit 5/7] test: shrink LUA_CPATH and {DY}LD_LIBRARY_PATH Sergey Kaplun via Tarantool-patches
2024-09-23 7:18 ` [Tarantool-patches] [PATCH luajit 6/7] test: skip flaky tests with enabled table bump Sergey Kaplun via Tarantool-patches
2024-09-23 9:44 ` Sergey Bronnikov via Tarantool-patches
2024-09-23 11:08 ` Sergey Kaplun via Tarantool-patches [this message]
2024-09-23 7:18 ` [Tarantool-patches] [PATCH luajit 7/7] test: set LD_PRELOAD only when necessary Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvFMQ-Gnzsq7uAz5@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 6/7] test: skip flaky tests with enabled table bump' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox