From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: mandesero@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 luajit 2/3] ci: add Valgrind testing workflow
Date: Mon, 16 Sep 2024 11:09:29 +0300 [thread overview]
Message-ID: <ZufnubzeuoSVwe-4@root> (raw)
In-Reply-To: <20240912102153.163481-3-mandesero@gmail.com>
Hi, Maksim!
Thanks for the patch!
Please see my comment below.
On 12.09.24, mandesero@gmail.com wrote:
> From: Maksim Tiushev <mandesero@gmail.com>
<snipped>
> + runs-on: [self-hosted, regular, Linux, x86_64]
It is worth checking the arm64 architecture too.
It is useful for backporting patches like the following:
* 003f6856 ("FFI: Don't load PC from non-function object in FFI
continuation.") [1],
* 68ffbd31 ("FFI: Don't load PC from non-function object in FFI
continuation.") [2].
See the corresponding issue [3].
So, for this patchset, you should backport the aforementioned patches
first and add the valgrind check after.
> + name: >
<snipped>
> --
> 2.34.1
>
[1]: https://github.com/LuaJIT/LuaJIT/commit/003f6856
[2]: https://github.com/LuaJIT/LuaJIT/commit/68ffbd31
[3]: https://github.com/LuaJIT/LuaJIT/issues/743
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2024-09-16 8:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 10:21 [Tarantool-patches] [PATCH v2 luajit 0/3] Enable running tests with Valgrind, add CI " mandesero--- via Tarantool-patches
2024-09-12 10:21 ` [Tarantool-patches] [PATCH v2 luajit 1/3] cmake: run tests with Valgrind mandesero--- via Tarantool-patches
2024-09-12 18:52 ` Sergey Bronnikov via Tarantool-patches
2024-09-16 15:50 ` [Tarantool-patches] [PATCH v2 luajit 1/3] cmake: run tests with Valgrind " mandesero--- via Tarantool-patches
2024-09-16 7:25 ` [Tarantool-patches] [PATCH v2 luajit 1/3] " Sergey Kaplun via Tarantool-patches
2024-09-12 10:21 ` [Tarantool-patches] [PATCH v2 luajit 2/3] ci: add Valgrind testing workflow mandesero--- via Tarantool-patches
2024-09-12 18:58 ` Sergey Bronnikov via Tarantool-patches
2024-09-16 8:09 ` Sergey Kaplun via Tarantool-patches [this message]
2024-09-12 10:21 ` [Tarantool-patches] [PATCH v2 luajit 3/3] test: disable tests failing with Valgrind mandesero--- via Tarantool-patches
2024-09-12 19:01 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZufnubzeuoSVwe-4@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=mandesero@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 luajit 2/3] ci: add Valgrind testing workflow' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox