From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Fix various issues in recff_cdata_arith. Date: Tue, 10 Sep 2024 17:01:15 +0300 [thread overview] Message-ID: <ZuBRK1_Bfcyld5ez@root> (raw) In-Reply-To: <b09ad71b-5a4b-403f-9a48-872d098582cb@tarantool.org> Hi, Sergey! Thanks for the review! On 10.09.24, Sergey Bronnikov wrote: > Hi, Sergey, > > On 09.09.2024 18:37, Sergey Bronnikov via Tarantool-patches wrote: > > > > Hi, Sergey, > > > > thanks for the patch! see my comments below. > > > > On 21.08.2024 19:52, Sergey Kaplun wrote: > >> From: Mike Pall <mike> > >> <snipped> > >> --- > >> > >> Branch:https://github.com/tarantool/luajit/tree/skaplun/lj-1224-fix-jit-cdata-arith > >> Related issues: > >> *https://github.com/tarantool/tarantool/issues/10199 > >> *https://github.com/LuaJIT/LuaJIT/issues/1224 > >> > >> src/lj_crecord.c | 10 ++-- > >> .../lj-1224-fix-cdata-arith-ptr.test.lua | 48 +++++++++++++++++++ > > > > This test does not fail without fix (but repro from the issue does): > > > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > ./build/gc64/src/luajit -Ohotloop=1 -e " > > repeat > > r = 1LL + nil > > until true > > " > > LuaJIT ASSERT > > /home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/lj_ctype.c:185: > > lj_ctype_intern: uninitialized cts->L > > Aborted > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > ./build/gc64/src/luajit > > test/tarantool-tests/lj-1224-fix-cdata-arith-ptr.test.lua > > TAP version 13 > > 1..2 > > # cdata arithmetic with nil > > 1..2 > > ok - correct recording error with bad cdata arithmetic > > ok - correct error message > > # cdata arithmetic with nil: end > > ok - cdata arithmetic with nil > > # cdata arithmetic with string > > 1..2 > > ok - correct recording error with bad cdata arithmetic > > ok - correct error message > > # cdata arithmetic with string: end > > ok - cdata arithmetic with string > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > > > With GC64 only (LUAJIT_ENABLE_GC64). It don't fail with GC64? Should I add the comment? > <snipped> -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2024-09-10 14:01 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-08-21 16:52 Sergey Kaplun via Tarantool-patches 2024-09-09 15:37 ` Sergey Bronnikov via Tarantool-patches 2024-09-10 10:04 ` Sergey Bronnikov via Tarantool-patches 2024-09-10 14:01 ` Sergey Kaplun via Tarantool-patches [this message] 2024-09-12 10:16 ` Sergey Kaplun via Tarantool-patches 2024-09-12 11:45 ` Sergey Bronnikov via Tarantool-patches 2024-09-23 7:21 ` Maxim Kokryashkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZuBRK1_Bfcyld5ez@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] FFI: Fix various issues in recff_cdata_arith.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox