From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0358AD1AF13; Tue, 10 Sep 2024 17:01:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0358AD1AF13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1725976887; bh=kdpTM5QfgaT71qmlyjVeqxzf2+SHI5x/TA/8DhL9rnw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IIdxsiDgxfK0QWobCLw5KpY/FqnAbZcJ/+2vJLrX5ppz1govah1RJsYpL13pFcvBm MQzg9X8Rid+35lSiwEeUuQ1eO2jsRuFE33CIGTIC2PENalQ7hbhUxK2txf3Ru4ZJLP igx6VF3uEtITx7jFkFd+Lf9kZZb5I1yKQw+kaQQg= Received: from smtp17.i.mail.ru (smtp17.i.mail.ru [95.163.41.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5958FD1AF01 for ; Tue, 10 Sep 2024 17:01:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5958FD1AF01 Received: by smtp17.i.mail.ru with esmtpa (envelope-from ) id 1so1Qq-0000000H62Y-0TGv; Tue, 10 Sep 2024 17:01:24 +0300 Date: Tue, 10 Sep 2024 17:01:15 +0300 To: Sergey Bronnikov Message-ID: References: <20240821165250.11087-1-skaplun@tarantool.org> <5f51a9ad-3302-4e0c-8d91-c5a26c147fe2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9C95DBF42ADE189BE3AA9D9EC9D5B3A9853A40ECE2FF72C03182A05F5380850404C228DA9ACA6FE27B4021652CE0D4F5389CEA9C911D0999552ABCB80313DE85AF3122B6640081EC5906DE0852CB233E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77D3344F2D0C9F5BEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A164EE347039141E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C2E8EBAFC355C530A58B6D8D51B469001E946C4F785CE3B9CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F790063741F7343E26298569389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FCF1175FABE1C0F9B6E2021AF6380DFAD18AA50765F7900637F09814068C508CC822CA9DD8327EE4930A3850AC1BE2E7356436AE5DD6441DC7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5FC1A2862AD7293455002B1117B3ED696BAFEACDA62F80D3BCA7E60A991436CA2823CB91A9FED034534781492E4B8EEADC24E78AA85F86F6CBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF1781A8C5BAE0EF53F055F9DE7DC94E3AD8E012D584AD1B647829FDDFE637AFC6136DDA45E01CE4BEBA3E0C39EEA44CB37A1AD81E8D7FADA68EDB0F21D06EEA24B878DD08370B0B495F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNj77dOQFim1Oz2/oaXtE3g== X-DA7885C5: E6D18F5BA21F63F8F255D290C0D534F9ECC77EA2F810C6181FA7F53495885346E39D05F12418B9CD5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BB65162D3E9072B2AE248B374534ED5EEC7A0A3FD5DF6C1BFE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Fix various issues in recff_cdata_arith. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 10.09.24, Sergey Bronnikov wrote: > Hi, Sergey, > > On 09.09.2024 18:37, Sergey Bronnikov via Tarantool-patches wrote: > > > > Hi, Sergey, > > > > thanks for the patch! see my comments below. > > > > On 21.08.2024 19:52, Sergey Kaplun wrote: > >> From: Mike Pall > >> > >> --- > >> > >> Branch:https://github.com/tarantool/luajit/tree/skaplun/lj-1224-fix-jit-cdata-arith > >> Related issues: > >> *https://github.com/tarantool/tarantool/issues/10199 > >> *https://github.com/LuaJIT/LuaJIT/issues/1224 > >> > >> src/lj_crecord.c | 10 ++-- > >> .../lj-1224-fix-cdata-arith-ptr.test.lua | 48 +++++++++++++++++++ > > > > This test does not fail without fix (but repro from the issue does): > > > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > ./build/gc64/src/luajit -Ohotloop=1 -e " > > repeat > >   r = 1LL + nil > > until true > > " > > LuaJIT ASSERT > > /home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/lj_ctype.c:185: > > lj_ctype_intern: uninitialized cts->L > > Aborted > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > ./build/gc64/src/luajit > > test/tarantool-tests/lj-1224-fix-cdata-arith-ptr.test.lua > > TAP version 13 > > 1..2 > >     # cdata arithmetic with nil > > 1..2 > >     ok - correct recording error with bad cdata arithmetic > >     ok - correct error message > >     # cdata arithmetic with nil: end > > ok - cdata arithmetic with nil > >     # cdata arithmetic with string > >     1..2 > >     ok - correct recording error with bad cdata arithmetic > >     ok - correct error message > >     # cdata arithmetic with string: end > > ok - cdata arithmetic with string > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > > > With GC64 only (LUAJIT_ENABLE_GC64). It don't fail with GC64? Should I add the comment? > -- Best regards, Sergey Kaplun