From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent sanitizer warning in snap_restoredata().
Date: Thu, 4 Jul 2024 11:41:47 +0300 [thread overview]
Message-ID: <ZoZgS-jKuK9eczM4@root> (raw)
In-Reply-To: <13a5ffa5-c7b4-4476-8969-5dd5c9fadf50@tarantool.org>
Hi, Sergey!
Thanks for the review!
Added the corresponding line, as you suggested. Branch is force pushed.
On 04.07.24, Sergey Bronnikov wrote:
> Hi, Sergey,
>
> thanks for the patch!
>
> Please add a message "Also, it removes all related UBSAN suppressions,
> since they are fixed."
>
> to commit message, like you did for the second patch.
>
>
> LGTM
>
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2024-07-04 8:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 15:54 [Tarantool-patches] [PATCH luajit 0/2] Fix UBSan warnings Sergey Kaplun via Tarantool-patches
2024-06-25 15:54 ` [Tarantool-patches] [PATCH luajit 1/2] Prevent sanitizer warning in snap_restoredata() Sergey Kaplun via Tarantool-patches
2024-07-01 8:44 ` Maxim Kokryashkin via Tarantool-patches
2024-07-04 7:58 ` Sergey Bronnikov via Tarantool-patches
2024-07-04 8:41 ` Sergey Kaplun via Tarantool-patches [this message]
2024-07-04 14:59 ` Sergey Bronnikov via Tarantool-patches
2024-06-25 15:54 ` [Tarantool-patches] [PATCH luajit 2/2] Avoid negation of signed integers in C that may hold INT*_MIN Sergey Kaplun via Tarantool-patches
2024-07-01 9:11 ` Maxim Kokryashkin via Tarantool-patches
2024-07-01 10:12 ` Sergey Kaplun via Tarantool-patches
2024-07-04 8:08 ` Sergey Bronnikov via Tarantool-patches
2024-07-04 8:40 ` Sergey Kaplun via Tarantool-patches
2024-07-04 14:59 ` Sergey Bronnikov via Tarantool-patches
2024-07-09 8:08 ` [Tarantool-patches] [PATCH luajit 0/2] Fix UBSan warnings Sergey Kaplun via Tarantool-patches
2024-07-09 8:15 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoZgS-jKuK9eczM4@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent sanitizer warning in snap_restoredata().' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox