Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] build: introduce LUAJIT_USE_UBSAN option
Date: Thu, 20 Jun 2024 13:03:10 +0300	[thread overview]
Message-ID: <ZnP-Xu-HJncl2Q32@root> (raw)
In-Reply-To: <ccf8a42e-ad88-443a-94fb-39d546706eb0@tarantool.org>

Hi, Sergey!
Thanks for the reply!

On 20.06.24, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> On 16.05.2024 13:14, Sergey Kaplun wrote:
> > Hi, folks!
> > Some more thoughts below.
> >
> > On 15.05.24, Sergey Kaplun wrote:
> >
> > <snipped>
> >
> >> +  string(JOIN "," UBSAN_IGNORE_OPTIONS
> >> +    # Misaligned pseudo-pointers are used to determine internal
> >> +    # variable names inside the `for` cycle.
> >> +    alignment
> >> +    # Not interested in float cast overflow errors.
> >> +    float-cast-overflow
> >> +    # NULL checking is disabled because this is not a UB and
> >> +    # raises lots of false-positive fails.
> >> +    null
> > Maybe it is worth to add also "nonnull-attribute" to the ignore options:
> >
> > ```
> > LSAN_OPTIONS="abort_on_error=1" src/luajit -e 'error("bad usage", 3)'
> > /home/burii/builds_workspace/luajit/gh-8473-ubsan/src/lj_buf.h:75:25: runtime error: null pointer passed as argument 1, which is declared to never be null
> > /usr/include/string.h:44:28: note: nonnull attribute specified here
> > ```
> >
> > Here, `memcpy()` gets the NULL pointer as the first argument and the
> > `len` == 0. So there are no problems here. Also, the nullability
> > violation is not a UB, as mentioned in the documentation.
> >
> > Thoughts?
> 
> I agree with arguments provided by Maxim - it's UB, the standard states 
> it clearly,
> 
> and it should be fixed. I propose to do the following:
> 
> - suppress the check (add it to UBSAN_IGNORE_OPTIONS) with appropriate 
> comment
> 
> (something like "we know it is bad, but it is unfixed in upstream, we 
> will wait a fix").
> 
> Probably we should suppress it per file like you did with other checks.

I suppress this particular failure inline, like for other checks.
Should I add the test for it?

> 
> - send a fix to upstream or submit an issue to the upstream (I'll not 
> insist, but it would be desirable)

I suppose this issue will be marked as won't fix or invalid. Feel free
to submit the ticket if you want.

> 
> >

<snipped>

> >> +  )

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2024-06-20 10:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 12:31 [Tarantool-patches] [PATCH luajit 0/2] Add UBSan support Sergey Kaplun via Tarantool-patches
2024-05-15 12:32 ` [Tarantool-patches] [PATCH luajit 1/2] build: introduce LUAJIT_USE_UBSAN option Sergey Kaplun via Tarantool-patches
2024-05-16 10:14   ` Sergey Kaplun via Tarantool-patches
2024-05-26  9:56     ` Maxim Kokryashkin via Tarantool-patches
2024-05-27  7:22       ` Sergey Kaplun via Tarantool-patches
2024-05-27  8:28         ` Maxim Kokryashkin via Tarantool-patches
2024-06-20 10:01     ` Sergey Bronnikov via Tarantool-patches
2024-06-20 10:03       ` Sergey Kaplun via Tarantool-patches [this message]
2024-05-27  8:52   ` Maxim Kokryashkin via Tarantool-patches
2024-05-27 12:28     ` Sergey Kaplun via Tarantool-patches
2024-06-14 12:03       ` Maxim Kokryashkin via Tarantool-patches
2024-06-07 10:17   ` Sergey Bronnikov via Tarantool-patches
2024-06-13 10:56     ` Sergey Kaplun via Tarantool-patches
2024-06-13 15:13       ` Sergey Bronnikov via Tarantool-patches
2024-05-15 12:32 ` [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow Sergey Kaplun via Tarantool-patches
2024-05-26  9:50   ` Maxim Kokryashkin via Tarantool-patches
2024-05-27 12:30     ` Sergey Kaplun via Tarantool-patches
2024-06-07 10:20   ` Sergey Bronnikov via Tarantool-patches
2024-06-13 10:35     ` Sergey Kaplun via Tarantool-patches
2024-06-13 15:06       ` Sergey Bronnikov via Tarantool-patches
2024-07-09  8:06 ` [Tarantool-patches] [PATCH luajit 0/2] Add UBSan support Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnP-Xu-HJncl2Q32@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] build: introduce LUAJIT_USE_UBSAN option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox