From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 3/4] FFI: Allow ffi.metatype() for typedefs with attributes.
Date: Thu, 13 Jun 2024 10:34:21 +0300 [thread overview]
Message-ID: <Zmqg_VsmErGX6-Xw@root> (raw)
In-Reply-To: <c37f18a9-230a-49d5-9db5-1f3ad5ebea0b@tarantool.org>
Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.
On 11.06.24, Sergey Bronnikov wrote:
> Hi, Sergey
>
> thanks for the patch! LGTM with a nit below.
>
> On 03.06.2024 17:34, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Reported by Eric Gouyer.
> >
> > (cherry picked from commit 27a6fee82e91319bbed8c3aa443aa2b0f1b0a470)
> >
> > Before the patch, `ffi.metatype()` raises an error when calling it on
> > ctype with attributes. This patch fixes the behaviour by using
> extra whitespace above
> > `ctype_raw()` instead of `ctype_get()` to follow child ctypes unless
> > there are no attributes on the ctype.
> >
> > Sergey Kaplun:
> > * added the description and the test for the problem
> >
> > Part of tarantool/tarantool#9924
> > ---
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2024-06-13 7:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 14:33 [Tarantool-patches] [PATCH luajit 0/4] Fixes for ctypes " Sergey Kaplun via Tarantool-patches
2024-06-03 14:33 ` [Tarantool-patches] [PATCH luajit 1/4] FFI: Fix ffi.alignof() for reference types Sergey Kaplun via Tarantool-patches
2024-06-11 15:40 ` Sergey Bronnikov via Tarantool-patches
2024-06-14 12:19 ` Maxim Kokryashkin via Tarantool-patches
2024-06-03 14:34 ` [Tarantool-patches] [PATCH luajit 2/4] FFI: Fix sizeof expression in C parser " Sergey Kaplun via Tarantool-patches
2024-06-11 15:42 ` Sergey Bronnikov via Tarantool-patches
2024-06-14 12:21 ` Maxim Kokryashkin via Tarantool-patches
2024-06-03 14:34 ` [Tarantool-patches] [PATCH luajit 3/4] FFI: Allow ffi.metatype() for typedefs with attributes Sergey Kaplun via Tarantool-patches
2024-06-11 15:48 ` Sergey Bronnikov via Tarantool-patches
2024-06-13 7:34 ` Sergey Kaplun via Tarantool-patches [this message]
2024-06-13 15:14 ` Sergey Bronnikov via Tarantool-patches
2024-06-14 12:39 ` Maxim Kokryashkin via Tarantool-patches
2024-06-03 14:34 ` [Tarantool-patches] [PATCH luajit 4/4] FFI: Fix ffi.metatype() for non-raw types Sergey Kaplun via Tarantool-patches
2024-06-11 15:50 ` Sergey Bronnikov via Tarantool-patches
2024-06-14 12:40 ` Maxim Kokryashkin via Tarantool-patches
2024-07-09 8:03 ` [Tarantool-patches] [PATCH luajit 0/4] Fixes for ctypes with attributes Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmqg_VsmErGX6-Xw@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 3/4] FFI: Allow ffi.metatype() for typedefs with attributes.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox