From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v1 5/5] Use generic trace error for OOM during trace stitching.
Date: Sun, 16 Jun 2024 22:13:23 +0300 [thread overview]
Message-ID: <Zm85U4ZrIoHp1jQ2@root> (raw)
In-Reply-To: <fb56a84a-847d-4ff1-8649-ee1e4ca0dcb4@tarantool.org>
Hi, Sergey!
On 13.06.24, Sergey Bronnikov wrote:
> Hi, Sergey
>
> thanks for the answers.
<snipped>
> >>> mockalloc.unmock()
> >> Same comment as in previous mail - let's avoid name 'mock' here.
> > But we actually mock the allocator here, don't we?
> > Thus, I renamed the new allocated function to avoid confusion.
> > If you insist, please suggest the correct name instead `mock` |
> > `unmock`.
>
> We can replace "mock"/"unmock" to "{enable, disable} error injection".
>
> Actually, I don't want to insist. I'm ok if it wouldn't confuse anyone.
Replaced in the 2nd verison of the patch-set [1].
>
> >>>
> > <snipped>
> >
> >>> test:done(true)
> > [1]:https://lists.tarantool.org/pipermail/tarantool-patches/2024-June/029218.html
> >
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2024-June/029242.html
--
Best regards,
Sergey Kaplun
prev parent reply other threads:[~2024-06-16 19:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 8:49 [Tarantool-patches] [PATCH luajit v1 0/5] Handle all errors during stitching Sergey Kaplun via Tarantool-patches
2024-04-22 8:49 ` [Tarantool-patches] [PATCH luajit v1 1/5] build: introduce option LUAJIT_ENABLE_TABLE_BUMP Sergey Kaplun via Tarantool-patches
2024-05-05 12:39 ` Maxim Kokryashkin via Tarantool-patches
2024-05-13 11:47 ` Sergey Kaplun via Tarantool-patches
2024-06-06 10:53 ` Sergey Bronnikov via Tarantool-patches
2024-06-13 9:51 ` Sergey Kaplun via Tarantool-patches
2024-06-13 14:37 ` Sergey Bronnikov via Tarantool-patches
2024-04-22 8:49 ` [Tarantool-patches] [PATCH luajit v1 2/5] ci: add tablebump flavor for exotic builds Sergey Kaplun via Tarantool-patches
2024-05-05 12:40 ` Maxim Kokryashkin via Tarantool-patches
2024-05-13 11:49 ` Sergey Kaplun via Tarantool-patches
2024-06-06 10:56 ` Sergey Bronnikov via Tarantool-patches
2024-04-22 8:49 ` [Tarantool-patches] [PATCH luajit v1 3/5] test: allow `jit.parse` to return aborted traces Sergey Kaplun via Tarantool-patches
2024-05-05 12:55 ` Maxim Kokryashkin via Tarantool-patches
2024-05-13 11:53 ` Sergey Kaplun via Tarantool-patches
2024-06-06 11:01 ` Sergey Bronnikov via Tarantool-patches
2024-06-13 10:00 ` Sergey Kaplun via Tarantool-patches
2024-06-13 14:38 ` Sergey Bronnikov via Tarantool-patches
2024-04-22 8:49 ` [Tarantool-patches] [PATCH luajit v1 4/5] Handle all types of errors during trace stitching Sergey Kaplun via Tarantool-patches
2024-05-06 8:25 ` Maxim Kokryashkin via Tarantool-patches
2024-06-06 13:03 ` Sergey Bronnikov via Tarantool-patches
2024-06-13 10:25 ` Sergey Kaplun via Tarantool-patches
2024-06-13 14:52 ` Sergey Bronnikov via Tarantool-patches
2024-04-22 8:49 ` [Tarantool-patches] [PATCH luajit v1 5/5] Use generic trace error for OOM " Sergey Kaplun via Tarantool-patches
2024-05-06 8:27 ` Maxim Kokryashkin via Tarantool-patches
2024-06-06 14:06 ` Sergey Bronnikov via Tarantool-patches
2024-06-13 10:31 ` Sergey Kaplun via Tarantool-patches
2024-06-13 14:58 ` Sergey Bronnikov via Tarantool-patches
2024-06-16 19:13 ` Sergey Kaplun via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zm85U4ZrIoHp1jQ2@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v1 5/5] Use generic trace error for OOM during trace stitching.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox