[Tarantool-patches] [PATCH v2 luajit 0/5] Handle all errors during stitching

[Tarantool-patches] [PATCH v2 luajit 0/5] Handle all errors during stitching

[Sergey Kaplun via Tarantool-patches]

This patchset handles all possible error types that may be observed
during stitching. The first 2 patches add an option to enable table bump
optimization for CMake options and add it to the CI exotic build
correspondingly. The third patch enhances the <jit/parse.lua> testing
utility to return IRs of aborted trace as well. Also, the reason for the
abort of a trace may be examined. The last 2 patches handle all possible
errors during stitching and ensure that the output of `jit.dump()` is
valid for all cases.

Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1166-errors-stitching
Related Issues:
* https://github.com/LuaJIT/LuaJIT/issues/1166
* https://github.com/LuaJIT/LuaJIT/pull/720
* https://github.com/LuaJIT/LuaJIT/issues/606
* https://github.com/tarantool/tarantool/issues/9924

Changes in v2:
* Renamed `mockalloc` Lua C library to the `allocinject`
* Renamed {mock, unmock} -> {enable, disable}
* Dropped luacheck inline suppressions for _TARANTOOL
* Fixed typos and added comments

Mike Pall (2):
  Handle all types of errors during trace stitching.
  Use generic trace error for OOM during trace stitching.

Sergey Kaplun (3):
  build: introduce option LUAJIT_ENABLE_TABLE_BUMP
  ci: add tablebump flavor for exotic builds
  test: allow `jit.parse` to return aborted traces

 .github/workflows/exotic-builds-testing.yml   | 10 +-
 CMakeLists.txt                                | 17 ++++
 src/lj_ffrecord.c                             | 23 ++++-
 test/tarantool-tests/CMakeLists.txt           |  1 +
 .../lj-1166-error-stitch-oom-ir-buff.test.lua | 92 +++++++++++++++++++
 ...j-1166-error-stitch-oom-snap-buff.test.lua | 91 ++++++++++++++++++
 .../lj-1166-error-stitch-table-bump.test.lua  | 38 ++++++++
 .../lj-1166-error-stitch/CMakeLists.txt       |  1 +
 .../lj-1166-error-stitch/allocinject.c        | 52 +++++++++++
 .../lj-720-errors-before-stitch.test.lua      | 40 +++++++-
 .../unit-jit-parse-abort.test.lua             | 38 ++++++++
 test/tarantool-tests/utils/jit/parse.lua      | 24 ++++-
 12 files changed, 414 insertions(+), 13 deletions(-)
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch-oom-ir-buff.test.lua
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch-oom-snap-buff.test.lua
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch-table-bump.test.lua
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch/CMakeLists.txt
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch/allocinject.c
 create mode 100644 test/tarantool-tests/unit-jit-parse-abort.test.lua

-- 
2.45.1

Re: [Tarantool-patches] [PATCH v2 luajit 0/5] Handle all errors during stitching

[Sergey Kaplun via Tarantool-patches]

Sorry guys, I've messed up with Message-ID. Please ignore this mail.

-- 
Best regards,
Sergey Kaplun

[Tarantool-patches] [PATCH v2 luajit 0/5] Handle all errors during stitching

[Sergey Kaplun via Tarantool-patches]

This patchset handles all possible error types that may be observed
during stitching. The first 2 patches add an option to enable table bump
optimization for CMake options and add it to the CI exotic build
correspondingly. The third patch enhances the <jit/parse.lua> testing
utility to return IRs of aborted trace as well. Also, the reason for the
abort of a trace may be examined. The last 2 patches handle all possible
errors during stitching and ensure that the output of `jit.dump()` is
valid for all cases.

Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1166-errors-stitching
Related Issues:
* https://github.com/LuaJIT/LuaJIT/issues/1166
* https://github.com/LuaJIT/LuaJIT/pull/720
* https://github.com/LuaJIT/LuaJIT/issues/606
* https://github.com/tarantool/tarantool/issues/9924

Changes in v2:
* Renamed `mockalloc` Lua C library to the `allocinject`
* Renamed {mock, unmock} -> {enable, disable}
* Dropped luacheck inline suppressions for _TARANTOOL
* Fixed typos and added comments

Mike Pall (2):
  Handle all types of errors during trace stitching.
  Use generic trace error for OOM during trace stitching.

Sergey Kaplun (3):
  build: introduce option LUAJIT_ENABLE_TABLE_BUMP
  ci: add tablebump flavor for exotic builds
  test: allow `jit.parse` to return aborted traces

 .github/workflows/exotic-builds-testing.yml   | 10 +-
 CMakeLists.txt                                | 17 ++++
 src/lj_ffrecord.c                             | 23 ++++-
 test/tarantool-tests/CMakeLists.txt           |  1 +
 .../lj-1166-error-stitch-oom-ir-buff.test.lua | 92 +++++++++++++++++++
 ...j-1166-error-stitch-oom-snap-buff.test.lua | 91 ++++++++++++++++++
 .../lj-1166-error-stitch-table-bump.test.lua  | 38 ++++++++
 .../lj-1166-error-stitch/CMakeLists.txt       |  1 +
 .../lj-1166-error-stitch/allocinject.c        | 52 +++++++++++
 .../lj-720-errors-before-stitch.test.lua      | 40 +++++++-
 .../unit-jit-parse-abort.test.lua             | 38 ++++++++
 test/tarantool-tests/utils/jit/parse.lua      | 24 ++++-
 12 files changed, 414 insertions(+), 13 deletions(-)
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch-oom-ir-buff.test.lua
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch-oom-snap-buff.test.lua
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch-table-bump.test.lua
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch/CMakeLists.txt
 create mode 100644 test/tarantool-tests/lj-1166-error-stitch/allocinject.c
 create mode 100644 test/tarantool-tests/unit-jit-parse-abort.test.lua

-- 
2.45.1

Re: [Tarantool-patches] [PATCH v2 luajit 0/5] Handle all errors during stitching

[Sergey Bronnikov via Tarantool-patches]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi, Sergey!

On 16.06.2024 13:01, Sergey Kaplun wrote:
> This patchset handles all possible error types that may be observed
> during stitching. The first 2 patches add an option to enable table bump
> optimization for CMake options and add it to the CI exotic build
> correspondingly. The third patch enhances the <jit/parse.lua> testing
> utility to return IRs of aborted trace as well. Also, the reason for the
> abort of a trace may be examined. The last 2 patches handle all possible
> errors during stitching and ensure that the output of `jit.dump()` is
> alid for all cases.

Patch series LGTM.


[-- Attachment #2: Type: text/html, Size: 1058 bytes --]

Re: [Tarantool-patches] [PATCH v2 luajit 0/5] Handle all errors during stitching

[Sergey Kaplun via Tarantool-patches]

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master [1], release/3.1 [2]
and release/2.11 [3].

[1]: https://github.com/tarantool/tarantool/pull/10200
[2]: https://github.com/tarantool/tarantool/pull/10201
[3]: https://github.com/tarantool/tarantool/pull/10202

-- 
Best regards,
Sergey Kaplun