Re: [Tarantool-patches] [PATCH luajit] Check for IR_HREF vs. IR_HREFK aliasing in non-nil store check.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review.
Fixed your comments and force-pushed the branch.

On 05.05.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for two nits below.
> On Wed, Apr 24, 2024 at 01:37:20PM UTC, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >

<snipped>

> > +
> > +-- Amount of iteration to compile and execute the trace.
> Typo: s/iteration/iterations/

Fixed, thanks!

> > +local LOOP_LIMIT = 4
> > +

<snipped>

> > +    -- with the corresponding snapshot is skipped.
> > +    -- The difference in the emitted IR before and afterthe patch
> Typo: s/afterthe/after the/

Fixed, thanks!
See the iterative patch below.

===================================================================
diff --git a/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua b/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua
index 6b72c97a..882ca780 100644
--- a/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua
+++ b/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua
@@ -15,7 +15,7 @@ local rawset = rawset
 -- field in HREFK IR.
 local HASH_NODES = 65535
 
--- Amount of iteration to compile and execute the trace.
+-- Amount of iterations to compile and execute the trace.
 local LOOP_LIMIT = 4
 
 -- Function to be called twice to emit the trace and take the side
@@ -42,7 +42,7 @@ local function trace_aliased_tables(t1, t2)
     -- `lj_opt_fwd_wasnonnil()` missed the check that HREFK and
     -- HREF may alias before the patch, so the guarded HLOAD IR
     -- with the corresponding snapshot is skipped.
-    -- The difference in the emitted IR before and afterthe patch
+    -- The difference in the emitted IR before and after the patch
     -- is the following:
     -- |  0004 >  tab SLOAD  #1    T
     -- |              ...
===================================================================

> > +    -- is the following:

<snipped>

-- 
Best regards,
Sergey Kaplun