Re: [Tarantool-patches] [PATCH luajit v1 2/5] ci: add tablebump flavor for exotic builds

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!
Fixed your comment. See the iterative patch below.

On 05.05.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for the single nit below.
> On Mon, Apr 22, 2024 at 11:49:55AM UTC, Sergey Kaplun wrote:
> > This flavor enables the LUAJIT_ENABLE_TABLE_BUMP option to test table
> > bump optimization.
> >
> > Needed for tarantool/tarantool#9924
> > ---

<snipped>

> >            # DUALNUM is default for ARM64, no need for additional testing.
> >            - FLAVOR: dualnum
> >              ARCH: ARM64
> > +          # Within table bump optimization enabled (and due to our modification
> Typo: s/Within/With/

Fixed.

> > +          # related to metrics), some offsets in GG_State stop fit in 12bit
> > +          # immediate. Hence, the build failed due to the DASM error
> > +          # (DASM_S_RANGE_I).
> > +          - FLAVOR: tablebump
> > +            ARCH: ARM64

===================================================================
diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
index 6ce100f4..70096439 100644
--- a/.github/workflows/exotic-builds-testing.yml
+++ b/.github/workflows/exotic-builds-testing.yml
@@ -58,10 +58,10 @@ jobs:
           # DUALNUM is default for ARM64, no need for additional testing.
           - FLAVOR: dualnum
             ARCH: ARM64
-          # Within table bump optimization enabled (and due to our modification
-          # related to metrics), some offsets in GG_State stop fit in 12bit
+          # With table bump optimization enabled (and due to our modification
+          # related to metrics), some offsets in GG_State stop fitting in 12bit
           # immediate. Hence, the build failed due to the DASM error
-          # (DASM_S_RANGE_I).
+          # (`DASM_S_RANGE_I`).
           - FLAVOR: tablebump
             ARCH: ARM64
     runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
===================================================================

-- 
Best regards,
Sergey Kaplun