[Tarantool-patches] [PATCH luajit] test: fix typo in the link to the issue

[Tarantool-patches] [PATCH luajit] test: fix typo in the link to the issue

[Sergey Kaplun via Tarantool-patches]

This patch is a follow-up to the
8ec08fc9ed5a6d2b2ee115572e0434a9f5dec99c ("Respect jit.off() on pending
trace exit."). It fixes the typo 'issue'->'issues' to correct the link.

Follows up tarantool/tarantool#9595
---

Since this is just a typo fix, I disabled integration testing (linters
will be disabled too for the "-notest" prefix, so it isn't omitted).

Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1134-fix-link-nointegration
Related issues:
* https://github.com/tarantool/tarantool/issues/9595
* https://github.com/LuaJIT/LuaJIT/issues/1134

 test/tarantool-tests/lj-1134-hotside-jit-off.test.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
index 080b1e87..27a778bc 100644
--- a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
+++ b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
@@ -2,7 +2,7 @@ local tap = require('tap')
 
 -- Test file to demonstrate the JIT misbehaviour, when the side
 -- trace is compiled after `jit.off()`.
--- See also: https://github.com/LuaJIT/LuaJIT/issue/1134.
+-- See also: https://github.com/LuaJIT/LuaJIT/issues/1134.
 
 local test = tap.test('lj-1134-hotside-jit-off'):skipcond({
   ['Test requires JIT enabled'] = not jit.status(),
-- 
2.44.0

Re: [Tarantool-patches] [PATCH luajit] test: fix typo in the link to the issue

[Maxim Kokryashkin via Tarantool-patches]

Hi, Sergey!
Thanks for the patch!
LGTM

Re: [Tarantool-patches] [PATCH luajit] test: fix typo in the link to the issue

[Sergey Bronnikov via Tarantool-patches]

LGTM

On 3/20/24 10:19, Sergey Kaplun wrote:
> This patch is a follow-up to the
> 8ec08fc9ed5a6d2b2ee115572e0434a9f5dec99c ("Respect jit.off() on pending
> trace exit."). It fixes the typo 'issue'->'issues' to correct the link.
>
> Follows up tarantool/tarantool#9595
> ---
>
> Since this is just a typo fix, I disabled integration testing (linters
> will be disabled too for the "-notest" prefix, so it isn't omitted).
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1134-fix-link-nointegration
> Related issues:
> * https://github.com/tarantool/tarantool/issues/9595
> * https://github.com/LuaJIT/LuaJIT/issues/1134
>
>   test/tarantool-tests/lj-1134-hotside-jit-off.test.lua | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> index 080b1e87..27a778bc 100644
> --- a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> +++ b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> @@ -2,7 +2,7 @@ local tap = require('tap')
>   
>   -- Test file to demonstrate the JIT misbehaviour, when the side
>   -- trace is compiled after `jit.off()`.
> --- See also: https://github.com/LuaJIT/LuaJIT/issue/1134.
> +-- See also: https://github.com/LuaJIT/LuaJIT/issues/1134.
>   
>   local test = tap.test('lj-1134-hotside-jit-off'):skipcond({
>     ['Test requires JIT enabled'] = not jit.status(),

Re: [Tarantool-patches] [PATCH luajit] test: fix typo in the link to the issue

[Sergey Kaplun via Tarantool-patches]

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master [1], release/3.0 [2]
and release/2.11 [3].

[1]: https://github.com/tarantool/tarantool/pull/9938
[2]: https://github.com/tarantool/tarantool/pull/9939
[3]: https://github.com/tarantool/tarantool/pull/9940

-- 
Best regards,
Sergey Kaplun