Re: [Tarantool-patches] [PATCH luajit v5] ci: extend tarantool integration testing

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Max!
Patch LGTM, except a few nits regarding the commit message and
comments.

Also, may you please provide two separate patches regarding backporting
to the tarantool/release/3.0 and tarantool/release/2.11 branches?

On 11.03.24, Maksim Kokryashkin wrote:
> From: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
> 
> This patch makes use of reusable workflows from the
> Tarantool repository, so now LuaJIT CI tests integration
> in all relevant workflows.
> 
> Also, this patch disables MacOS testing for Tarantool
> integration since those runs were made nightly in the
> Tarantool repo.
> 
> As noted in the documentation [1], it is impossible for a single
> workflow call tree to include more than 20 workflows. To
> overcome this limitation, workflows are started in a bunch of
> separate files. This makes it impossible to depend on LuaJIT-only
> jobs for integration workflows such as `tarantool-ecosystem.yml`
> or `tarantool-exotic.yml` since it is impossible to make

Nit: I suppose it should be "<integration-tarantool-ecosystem.yml> or
<integration-tarantool.yml>".

> cross-dependencies between workflow files.
> 

<snipped>

> ---
> 
> Changes in v5:
> - Added secrets section for integration-tarantool-ecosystem.yml to
>   resolve the issue with etcd-client integration.
> 
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/integration-testing
> 
>  .../integration-tarantool-ecosystem.yml       |  41 ++++++
>  .github/workflows/integration-tarantool.yml   | 118 ++++++++++++++++++
>  .github/workflows/testing.yml                 |   9 ++
>  3 files changed, 168 insertions(+)
>  create mode 100644 .github/workflows/integration-tarantool-ecosystem.yml
>  create mode 100644 .github/workflows/integration-tarantool.yml
> 
> diff --git a/.github/workflows/integration-tarantool-ecosystem.yml b/.github/workflows/integration-tarantool-ecosystem.yml
> new file mode 100644
> index 00000000..ccafd601
> --- /dev/null
> +++ b/.github/workflows/integration-tarantool-ecosystem.yml

<snipped>

> diff --git a/.github/workflows/integration-tarantool.yml b/.github/workflows/integration-tarantool.yml
> new file mode 100644
> index 00000000..cf5c7fb5
> --- /dev/null
> +++ b/.github/workflows/integration-tarantool.yml

<snipped>

> diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> index cb4ba57b..1581c8fc 100644
> --- a/.github/workflows/testing.yml
> +++ b/.github/workflows/testing.yml
> @@ -1,3 +1,11 @@
> +# XXX: A single call tree for reusable workflows can't exceed the
> +# total of 20 workflows, as stated in the documentation [1].
> +# Some other jobs are started in separate workflow files to
> +# overcome the limitation. The jobs are Tarantool ecosystem
> +# integration testing (tarantool-ecosystem.yml) and exotic
> +# Tarantool builds (tarantool-exotic.yml).

Nit: I suppose it should be "integration testing of Tarantool
<integration-tarantool.yml> and its ecosystem
<integration-tarantool-ecosystem.yml>".

> +#
> +# [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations
>  name: Testing
> 
>  on:
> @@ -108,6 +116,7 @@ jobs:

<snipped>

> 

-- 
Best regards,
Sergey Kaplun