Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/3][v2] Fix C file generation in jit.bcsave.
Date: Thu, 29 Feb 2024 07:40:38 +0000	[thread overview]
Message-ID: <ZeA09h_oA37uAODP@tarantool.org> (raw)
In-Reply-To: <cover.1699534835.git.sergeyb@tarantool.org>

Sergey,

Thanks for the series! I've touched the patchset here[1] and there[2],
to make it LGTM.

On 09.11.23, Sergey Bronnikov via Tarantool-patches wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Changes in v2:
> 
> - added patch "Add 'cc' file type for saving bytecode."
> - updated building test libraries
> - add test for C library as well
> - small refactoring in test/tarantool-tests/CMakeLists.txt
> 
> PR: https://github.com/tarantool/tarantool/pull/9276
> Epic: https://github.com/tarantool/tarantool/issues/9145
> Issue: none
> 
> Mike Pall (2):
>   Add 'cc' file type for saving bytecode.
>   Fix C file generation in jit.bcsave.
> 
> Sergey Bronnikov (1):
>   test: set dependencies to tarantool-tests explicitly
> 
>  doc/running.html                              |  3 +-
>  src/jit/bcsave.lua                            |  6 +--
>  test/tarantool-tests/CMakeLists.txt           | 18 +++----
>  .../lj-551-bytecode-c-broken-macro.test.lua   | 16 +++++++
>  .../CMakeLists.txt                            | 47 +++++++++++++++++++
>  .../bcsaved.lua                               |  3 ++
>  6 files changed, 77 insertions(+), 16 deletions(-)
>  create mode 100644 test/tarantool-tests/lj-551-bytecode-c-broken-macro.test.lua
>  create mode 100644 test/tarantool-tests/lj-551-bytecode-c-broken-macro/CMakeLists.txt
>  create mode 100644 test/tarantool-tests/lj-551-bytecode-c-broken-macro/bcsaved.lua
> 
> -- 
> 2.34.1
> 

[1]: https://github.com/tarantool/luajit/commit/de66d19
[2]: https://github.com/tarantool/luajit/commit/01df6ae

-- 
Best regards,
IM

      parent reply	other threads:[~2024-02-29  7:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 13:06 Sergey Bronnikov via Tarantool-patches
2023-11-09 13:08 ` [Tarantool-patches] [PATCH luajit 1/3][v2] Add 'cc' file type for saving bytecode Sergey Bronnikov via Tarantool-patches
2023-11-13  7:04   ` Sergey Kaplun via Tarantool-patches
2023-11-15  9:39     ` Sergey Bronnikov via Tarantool-patches
2023-11-09 13:08 ` [Tarantool-patches] [PATCH luajit 2/3][v2] test: set dependencies to tarantool-tests explicitly Sergey Bronnikov via Tarantool-patches
2023-11-13  7:10   ` Sergey Kaplun via Tarantool-patches
2023-11-15 11:34     ` Sergey Bronnikov via Tarantool-patches
2023-11-09 13:08 ` [Tarantool-patches] [PATCH luajit 3/3][v2] Fix C file generation in jit.bcsave Sergey Bronnikov via Tarantool-patches
2023-11-13  7:10   ` Sergey Kaplun via Tarantool-patches
2024-02-29  7:40 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeA09h_oA37uAODP@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/3][v2] Fix C file generation in jit.bcsave.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox