From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/2][v3] Fix embedded bytecode loader
Date: Thu, 8 Feb 2024 15:52:14 +0000 [thread overview]
Message-ID: <ZcT4rv1TxrDxPanv@tarantool.org> (raw)
In-Reply-To: <cover.1697806970.git.sergeyb@tarantool.org>
Sergey,
Thanks for the fixes! I've made several touches here[1] and there[2][3]
to make the patch LGTM.
[1]: https://github.com/tarantool/luajit/commit/bf239af
[2]: https://github.com/tarantool/luajit/commit/aa17343
[3]: https://github.com/tarantool/luajit/commit/ee2f6ce
On 20.10.23, Sergey Bronnikov wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Epic: https://github.com/tarantool/tarantool/pull/9145
> PR: https://github.com/tarantool/tarantool/pull/8913
> Related issue: https://github.com/LuaJIT/LuaJIT/issues/549
> Branch: https://github.com/tarantool/luajit/tree/ligurio/lj-549-fix-embedded-bytecode-loader
> Patches v1: https://lists.tarantool.org/tarantool-patches/cover.1690300762.git.sergeyb@tarantool.org/
> Patches v2: https://lists.tarantool.org/tarantool-patches/cover.1693480177.git.sergeyb@tarantool.org/T/#t
>
> Changes v3:
> - removed fio helpers
> - build shared library by CMake
>
> Changes v2:
> - added a Lua test that reproduces a problem like reproducer do
> - added fixes according to comments from Maxim K. and Sergey K.
>
> Mike Pall (2):
> Fix embedded bytecode loader.
> Followup fix for embedded bytecode loader.
>
> src/lib_package.c | 4 +-
> src/lj_bcread.c | 10 +-
> src/lj_lex.c | 7 ++
> src/lj_lex.h | 1 +
> test/tarantool-c-tests/lj-549-lua-load.test.c | 111 ++++++++++++++++++
> test/tarantool-tests/CMakeLists.txt | 1 +
> .../lj-549-bytecode-loader.test.lua | 27 +++++
> .../lj-549-bytecode-loader/CMakeLists.txt | 20 ++++
> .../lj-549-bytecode-loader/script.lua | 3 +
> 9 files changed, 177 insertions(+), 7 deletions(-)
> create mode 100644 test/tarantool-c-tests/lj-549-lua-load.test.c
> create mode 100644 test/tarantool-tests/lj-549-bytecode-loader.test.lua
> create mode 100644 test/tarantool-tests/lj-549-bytecode-loader/CMakeLists.txt
> create mode 100644 test/tarantool-tests/lj-549-bytecode-loader/script.lua
>
> --
> 2.34.1
>
--
Best regards,
IM
next prev parent reply other threads:[~2024-02-08 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 13:17 Sergey Bronnikov via Tarantool-patches
2023-10-20 13:17 ` [Tarantool-patches] [PATCH luajit 1/2][v3] " Sergey Bronnikov via Tarantool-patches
2023-10-20 13:17 ` [Tarantool-patches] [PATCH luajit 2/2][v3] Followup fix for " Sergey Bronnikov via Tarantool-patches
2024-02-08 15:52 ` Igor Munkin via Tarantool-patches [this message]
2024-02-09 9:42 ` [Tarantool-patches] [PATCH luajit 0/2][v3] Fix " Sergey Bronnikov via Tarantool-patches
2024-02-15 13:49 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcT4rv1TxrDxPanv@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit 0/2][v3] Fix embedded bytecode loader' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox