Re: [Tarantool-patches] [PATCH luajit] Consider slots used by upvalues in use-def analysis.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 08.02.24, Sergey Bronnikov wrote:
> Hi, Sergey
> 
> thanks for the patch! LGTM with a minor comment
> 
> On 2/7/24 17:51, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Reported by XmiliaH.
> >
> > (cherry picked from commit 3a654999c6f00de4cb9e61232d23579442e544a0)
> >
> > `snap_usedef()` analysis doesn't check slots for child upvalues of the
> > currentlly recorded function in use-def analysis. Hence, such slots may
> typo: currentlly

Fixed, thanks!
The new commit message is the following:

| Consider slots used by upvalues in use-def analysis.
|
| Reported by XmiliaH.
|
| (cherry picked from commit 3a654999c6f00de4cb9e61232d23579442e544a0)
|
| `snap_usedef()` analysis doesn't check slots for child upvalues of the
| currently recorded function in use-def analysis. Hence, such slots may
| be considered unused and not stored in the snapshot. So on snapshot
| restoration, values from these slots may be lost.
|
| This patch adds a marking for all such local upvalues.
|
| Sergey Kaplun:
| * added the description and the test for the problem
|
| Part of tarantool/tarantool#9595

> > be considered unused and not stored in the snapshot. So on snapshot
> > restoration, values from these slots may be lost.
> >
> > This patch adds a marking for all such local upvalues.
> >
> > Sergey Kaplun:
> > * added the description and the test for the problem
> >
> > Part of tarantool/tarantool#9595
> > ---

-- 
Best regards,
Sergey Kaplun