From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Consider slots used by upvalues in use-def analysis. Date: Thu, 15 Feb 2024 13:48:57 +0000 [thread overview] Message-ID: <Zc4WSWnCc1gDK4u9@tarantool.org> (raw) In-Reply-To: <20240207145108.29786-1-skaplun@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 07.02.24, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall <mike> > > Reported by XmiliaH. > > (cherry picked from commit 3a654999c6f00de4cb9e61232d23579442e544a0) > > `snap_usedef()` analysis doesn't check slots for child upvalues of the > currentlly recorded function in use-def analysis. Hence, such slots may > be considered unused and not stored in the snapshot. So on snapshot > restoration, values from these slots may be lost. > > This patch adds a marking for all such local upvalues. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9595 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-737-snap-usedef-upvalues > Tarantool PR: https://github.com/tarantool/tarantool/pull/9662 > Related issues: > * https://github.com/tarantool/tarantool/issues/9595 > * https://github.com/LuaJIT/LuaJIT/issues/737 > > src/lj_snap.c | 35 +++++++++++- > .../lj-737-snap-use-def-upvalues.test.lua | 55 +++++++++++++++++++ > 2 files changed, 87 insertions(+), 3 deletions(-) > create mode 100644 test/tarantool-tests/lj-737-snap-use-def-upvalues.test.lua > <snipped> > -- > 2.43.0 > -- Best regards, IM
prev parent reply other threads:[~2024-02-15 14:00 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-07 14:51 Sergey Kaplun via Tarantool-patches 2024-02-08 11:11 ` Sergey Bronnikov via Tarantool-patches 2024-02-08 11:24 ` Sergey Kaplun via Tarantool-patches 2024-02-08 12:49 ` Sergey Bronnikov via Tarantool-patches 2024-02-09 16:54 ` Maxim Kokryashkin via Tarantool-patches 2024-02-15 13:48 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Zc4WSWnCc1gDK4u9@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Consider slots used by upvalues in use-def analysis.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox