From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4CC6BA5A5C9; Thu, 15 Feb 2024 17:00:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4CC6BA5A5C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708005626; bh=QzAleFp/h4ofnnRwHhfFK9Z5k5rsfw+aKRGGimhoM4Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=b4J2bc2ZFHlbAddcOzrPbgCIQTJAfIf9mZsNIey0awxh18xWWHtEQIFfMQRYw1Wje hc0UolEBnUwxMY5DwzZJqdv6ZUFykVUllzW6gluiWIjTD00zi8oVCF8uCAKB/7ksPX XqqSO9eMoxjfJbuNxe1IbcO7GDbptgJDVzTbFYe4= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3EA57A5A5C9 for ; Thu, 15 Feb 2024 17:00:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3EA57A5A5C9 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1racHo-0000000FhzB-14I2; Thu, 15 Feb 2024 17:00:24 +0300 Date: Thu, 15 Feb 2024 13:48:57 +0000 To: Sergey Kaplun Message-ID: References: <20240207145108.29786-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240207145108.29786-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9001F8F2F6BAD2021A9C1F32554F77B3470762C4BF7D77BE000894C459B0CD1B9F7223625F54AD6428E1BD8CF9C5DA8DFC54E0761B372D88E63B764629CC13828F8D9167951636B18 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE782A779A89F7D69B2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7F9D05773942AAE9CEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD871FA370C2AF16C2297DC7527E278A5E1AD16AD6E4252000F5AA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E478A468B35FE767117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF856009BA58C5E1BBBA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6EDF998CB16CCEE6976E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249957A4DEDD2346B42E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B658CDF7FFE3EBBCC0089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A53298C9E02665B66A5002B1117B3ED6963FDDCACC5ADB4083E99897350C7C491E823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF55AE5F8C0BC0BCE67116C7B66C2B3334AFC13BFDCEB6EBB1005EEDB17074A65546C06E59B4E814053168784816B2568484D247BE11021A45FA85FEC3DCB8689E817177E96325204FC226CC413062362A913E6812662D5F2A74A26541E23E71317A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQ9gr3ZFpXElaaLI3YeaYnA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5316805F424246C54468BD48BD36611AD34E830547C5399873E2A7001F21D2E1387F5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Consider slots used by upvalues in use-def analysis. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 07.02.24, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Reported by XmiliaH. > > (cherry picked from commit 3a654999c6f00de4cb9e61232d23579442e544a0) > > `snap_usedef()` analysis doesn't check slots for child upvalues of the > currentlly recorded function in use-def analysis. Hence, such slots may > be considered unused and not stored in the snapshot. So on snapshot > restoration, values from these slots may be lost. > > This patch adds a marking for all such local upvalues. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9595 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-737-snap-usedef-upvalues > Tarantool PR: https://github.com/tarantool/tarantool/pull/9662 > Related issues: > * https://github.com/tarantool/tarantool/issues/9595 > * https://github.com/LuaJIT/LuaJIT/issues/737 > > src/lj_snap.c | 35 +++++++++++- > .../lj-737-snap-use-def-upvalues.test.lua | 55 +++++++++++++++++++ > 2 files changed, 87 insertions(+), 3 deletions(-) > create mode 100644 test/tarantool-tests/lj-737-snap-use-def-upvalues.test.lua > > -- > 2.43.0 > -- Best regards, IM