Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH luajit] codehealth: fix the typo
@ 2024-01-24 14:17 Sergey Kaplun via Tarantool-patches
  2024-01-25  7:15 ` Sergey Bronnikov via Tarantool-patches
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2024-01-24 14:17 UTC (permalink / raw)
  To: Maxim Kokryashkin, Sergey Bronnikov; +Cc: tarantool-patches

Fix the typo found with codespell 2.2.6 in files with our own source
code.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-codespell

The Tarantool's CI is broken for macOS for now, so just ignore these red
crosses.

 test/tarantool-c-tests/misclib-getmetrics-capi.test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/tarantool-c-tests/misclib-getmetrics-capi.test.c b/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
index 1a4dce74..5bd619c6 100644
--- a/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
+++ b/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
@@ -210,7 +210,7 @@ static void check_snap_restores(lua_State *L)
 	luaM_metrics(L, &newm);
 	/*
 	 * Remove `snap_restores` from stack.
-	 * Must be done before potiential assert and exit from
+	 * Must be done before potential assert and exit from
 	 * the test.
 	 */
 	lua_pop(L, 1);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit] codehealth: fix the typo
  2024-01-24 14:17 [Tarantool-patches] [PATCH luajit] codehealth: fix the typo Sergey Kaplun via Tarantool-patches
@ 2024-01-25  7:15 ` Sergey Bronnikov via Tarantool-patches
  2024-01-29 10:39 ` Maxim Kokryashkin via Tarantool-patches
  2024-02-15 13:51 ` Igor Munkin via Tarantool-patches
  2 siblings, 0 replies; 4+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2024-01-25  7:15 UTC (permalink / raw)
  To: Sergey Kaplun, Maxim Kokryashkin; +Cc: tarantool-patches

Hi, Sergey!

thanks! LGTM

On 1/24/24 17:17, Sergey Kaplun wrote:
> Fix the typo found with codespell 2.2.6 in files with our own source
> code.
> ---
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-codespell
>
> The Tarantool's CI is broken for macOS for now, so just ignore these red
> crosses.
>
>   test/tarantool-c-tests/misclib-getmetrics-capi.test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/tarantool-c-tests/misclib-getmetrics-capi.test.c b/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
> index 1a4dce74..5bd619c6 100644
> --- a/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
> +++ b/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
> @@ -210,7 +210,7 @@ static void check_snap_restores(lua_State *L)
>   	luaM_metrics(L, &newm);
>   	/*
>   	 * Remove `snap_restores` from stack.
> -	 * Must be done before potiential assert and exit from
> +	 * Must be done before potential assert and exit from
>   	 * the test.
>   	 */
>   	lua_pop(L, 1);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches]  [PATCH luajit] codehealth: fix the typo
  2024-01-24 14:17 [Tarantool-patches] [PATCH luajit] codehealth: fix the typo Sergey Kaplun via Tarantool-patches
  2024-01-25  7:15 ` Sergey Bronnikov via Tarantool-patches
@ 2024-01-29 10:39 ` Maxim Kokryashkin via Tarantool-patches
  2024-02-15 13:51 ` Igor Munkin via Tarantool-patches
  2 siblings, 0 replies; 4+ messages in thread
From: Maxim Kokryashkin via Tarantool-patches @ 2024-01-29 10:39 UTC (permalink / raw)
  To: Sergey Kaplun; +Cc: tarantool-patches

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]


Hi!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
 
  
>Среда, 24 января 2024, 17:22 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
> 
>Fix the typo found with codespell 2.2.6 in files with our own source
>code.
>---
>
>Branch:  https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-codespell
>
>The Tarantool's CI is broken for macOS for now, so just ignore these red
>crosses.
>
> test/tarantool-c-tests/misclib-getmetrics-capi.test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/test/tarantool-c-tests/misclib-getmetrics-capi.test.c b/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
>index 1a4dce74..5bd619c6 100644
>--- a/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
>+++ b/test/tarantool-c-tests/misclib-getmetrics-capi.test.c
>@@ -210,7 +210,7 @@ static void check_snap_restores(lua_State *L)
>  luaM_metrics(L, &newm);
>  /*
>  * Remove `snap_restores` from stack.
>- * Must be done before potiential assert and exit from
>+ * Must be done before potential assert and exit from
>  * the test.
>  */
>  lua_pop(L, 1);
>--
>2.43.0
 

[-- Attachment #2: Type: text/html, Size: 1760 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH luajit] codehealth: fix the typo
  2024-01-24 14:17 [Tarantool-patches] [PATCH luajit] codehealth: fix the typo Sergey Kaplun via Tarantool-patches
  2024-01-25  7:15 ` Sergey Bronnikov via Tarantool-patches
  2024-01-29 10:39 ` Maxim Kokryashkin via Tarantool-patches
@ 2024-02-15 13:51 ` Igor Munkin via Tarantool-patches
  2 siblings, 0 replies; 4+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2024-02-15 13:51 UTC (permalink / raw)
  To: Sergey Kaplun; +Cc: tarantool-patches

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/3.0 and
release/2.11.

On 24.01.24, Sergey Kaplun via Tarantool-patches wrote:
> Fix the typo found with codespell 2.2.6 in files with our own source
> code.
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-codespell
> 
> The Tarantool's CI is broken for macOS for now, so just ignore these red
> crosses.
> 
>  test/tarantool-c-tests/misclib-getmetrics-capi.test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

<snipped>

> -- 
> 2.43.0
> 

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-15 14:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-24 14:17 [Tarantool-patches] [PATCH luajit] codehealth: fix the typo Sergey Kaplun via Tarantool-patches
2024-01-25  7:15 ` Sergey Bronnikov via Tarantool-patches
2024-01-29 10:39 ` Maxim Kokryashkin via Tarantool-patches
2024-02-15 13:51 ` Igor Munkin via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox