Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] Fix unsinking TNEW with huge asize
Date: Thu, 15 Feb 2024 13:45:47 +0000	[thread overview]
Message-ID: <Zc4Vizw9oZtoxJUo@tarantool.org> (raw)
In-Reply-To: <cover.1706104777.git.skaplun@tarantool.org>

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/3.0 and
release/2.11.

On 24.01.24, Sergey Kaplun via Tarantool-patches wrote:
> The first patch isn't necessary for the problem reproducer, but it
> simplifies it a lot. Plus, it's an easy optimization, so whatever.
> The second patch fixed the mentioned problem.
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1132-bad-snap-refs
> 
> The Tarantool's CI is broken for macOS for now, so just ignore these red
> crosses.
> 
> Tarantool PR: https://github.com/tarantool/tarantool/pull/9618
> Related issues:
> * https://github.com/tarantool/tarantool/issues/9595
> * https://github.com/LuaJIT/LuaJIT/issues/1128
> * https://github.com/LuaJIT/LuaJIT/issues/1132
> 
> 
> Mike Pall (2):
>   Optimize table.new() with constant args to (sinkable) IR_TNEW.
>   Only emit proper parent references in snapshot replay.
> 
>  src/lj_ffrecord.c                             |   9 ++
>  src/lj_snap.c                                 |  12 +-
>  .../lj-1128-table-new-opt-tnew.test.lua       | 112 ++++++++++++++++++
>  .../lj-1132-bad-snap-refs.test.lua            |  36 ++++++
>  4 files changed, 165 insertions(+), 4 deletions(-)
>  create mode 100644 test/tarantool-tests/lj-1128-table-new-opt-tnew.test.lua
>  create mode 100644 test/tarantool-tests/lj-1132-bad-snap-refs.test.lua
> 
> -- 
> 2.43.0
> 

-- 
Best regards,
IM

      parent reply	other threads:[~2024-02-15 13:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 14:11 Sergey Kaplun via Tarantool-patches
2024-01-24 14:11 ` [Tarantool-patches] [PATCH luajit 1/2] Optimize table.new() with constant args to (sinkable) IR_TNEW Sergey Kaplun via Tarantool-patches
2024-01-31  9:20   ` Maxim Kokryashkin via Tarantool-patches
2024-01-31  9:36     ` Sergey Kaplun via Tarantool-patches
2024-02-05 14:39   ` Sergey Bronnikov via Tarantool-patches
2024-01-24 14:11 ` [Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay Sergey Kaplun via Tarantool-patches
2024-01-31  9:29   ` Maxim Kokryashkin via Tarantool-patches
2024-02-06  9:46   ` Sergey Bronnikov via Tarantool-patches
2024-02-06 10:07     ` Sergey Kaplun via Tarantool-patches
2024-02-06 11:07       ` Sergey Bronnikov via Tarantool-patches
2024-02-06 11:41         ` Sergey Kaplun via Tarantool-patches
2024-02-08 14:12           ` Sergey Bronnikov via Tarantool-patches
2024-02-15 13:45 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zc4Vizw9oZtoxJUo@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Fix unsinking TNEW with huge asize' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox