From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Avoid out-of-range number of results when compiling select(k, ...). Date: Thu, 15 Feb 2024 13:47:22 +0000 [thread overview] Message-ID: <Zc4V6mcshBN-ZZr2@tarantool.org> (raw) In-Reply-To: <20240207120648.12416-1-skaplun@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 07.02.24, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall <mike> > > The interpreter will throw and abort the trace, anyway. > > (cherry picked from commit 6ca580155b035fd369f193cdee59391b594a5028) > > The `recff_select()` sets the amount of `RecordFFData` structure even > for a negative first argument when trace is not recording (since the > interpreter will throw an error anyway). This leads to excess IR > emission and possible reads of dirty memory. > > This patch updates the `rd->nres` only in the case when a trace will be > recorded. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9595 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-ff-select-recording > Tarantool PR: https://github.com/tarantool/tarantool/pull/9659 > Related issue: https://github.com/tarantool/tarantool/issues/9595 > > src/lj_ffrecord.c | 2 +- > .../fix-ff-select-recording.test.lua | 44 +++++++++++++++++++ > 2 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/fix-ff-select-recording.test.lua > <snipped> > -- > 2.43.0 > -- Best regards, IM
prev parent reply other threads:[~2024-02-15 13:58 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-07 12:06 Sergey Kaplun via Tarantool-patches 2024-02-08 9:30 ` Sergey Bronnikov via Tarantool-patches 2024-02-08 9:36 ` Sergey Kaplun via Tarantool-patches 2024-02-08 13:05 ` Sergey Bronnikov via Tarantool-patches 2024-02-08 13:57 ` Sergey Bronnikov via Tarantool-patches 2024-02-09 16:41 ` Maxim Kokryashkin via Tarantool-patches 2024-02-15 13:47 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Zc4V6mcshBN-ZZr2@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Avoid out-of-range number of results when compiling select(k, ...).' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox