From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <estetus@gmail.com> Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Always snapshot functions for non-base frames. Date: Thu, 15 Feb 2024 13:39:54 +0000 [thread overview] Message-ID: <Zc4UKlOrtR82svCD@tarantool.org> (raw) In-Reply-To: <8d9d59bf865fe5764a3c91d5a363f7e2bc78a348.1697115768.git.sergeyb@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 12.10.23, Sergey Bronnikov via Tarantool-patches wrote: > From: Sergey Bronnikov <sergeyb@tarantool.org> > > Reported by Arseny Vakhrushev. > Analysis and fix contributed by Peter Cawley. > > (cherry picked from commit ff1e72acead01df7d8ed0fbb31efd32f57953618) > > The problem is GC64-specific and could be reproduced with enabled > compiler options LUA_USE_ASSERT and LUA_USE_APICHECK. > > Sergey Kaplun: > * minimized reproducer made by fuzzing test > > Sergey Bronnikov: > * added the description (see a comment in the test) > * added tests for the problem: first one based on the original > reproducer and second one based on a reproducer made by fuzzing test. > > Part of tarantool/tarantool#8825 > --- > Branch: https://github.com/tarantool/luajit/commits/ligurio/lj-611-always-snapshot-functions-for-non-base-frames > PR: https://github.com/tarantool/tarantool/pull/9254 > LJ issue: https://github.com/LuaJIT/LuaJIT/issues/611 > > src/lj_record.c | 1 + > src/lj_snap.c | 9 +++- > ...t-functions-for-non-base-frames-1.test.lua | 36 +++++++++++++++ > ...hot-functions-for-non-base-frames.test.lua | 45 +++++++++++++++++++ > 4 files changed, 89 insertions(+), 2 deletions(-) > create mode 100644 test/tarantool-tests/lj-611-always-snapshot-functions-for-non-base-frames-1.test.lua > create mode 100644 test/tarantool-tests/lj-611-always-snapshot-functions-for-non-base-frames.test.lua > <snipped> > -- > 2.34.1 > -- Best regards, IM
prev parent reply other threads:[~2024-02-15 13:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-12 13:06 Sergey Bronnikov via Tarantool-patches 2023-10-17 14:56 ` Maxim Kokryashkin via Tarantool-patches 2023-10-18 14:59 ` Sergey Bronnikov via Tarantool-patches 2023-10-23 14:43 ` Sergey Kaplun via Tarantool-patches 2023-11-07 10:54 ` Maxim Kokryashkin via Tarantool-patches 2023-10-23 14:57 ` Sergey Kaplun via Tarantool-patches 2024-02-12 7:36 ` Sergey Kaplun via Tarantool-patches 2024-02-13 8:30 ` Sergey Bronnikov via Tarantool-patches 2024-02-13 10:58 ` Maxim Kokryashkin via Tarantool-patches 2024-02-15 13:39 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Zc4UKlOrtR82svCD@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Always snapshot functions for non-base frames.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox